Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround upstream issue in creating azureEndpoints in traffic manager #1546

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Workaround upstream issue in creating azureEndpoints in traffic manager #1546

merged 1 commit into from
Jul 12, 2018

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Jul 11, 2018

Fixes #1545

@phekmat phekmat mentioned this pull request Jul 11, 2018
Closed
@tombuildsstuff
Copy link
Contributor

Prior to this PR the Traffic Manager Endpoint tests failed with:

* azurerm_traffic_manager_endpoint.testAzure: trafficmanager.EndpointsClient#CreateOrUpdate: Failure responding to request: StatusCode=500 -- Original Error: autorest/azure: Service returned an error. Status=500 Code="Unknown" Message="Unknown service error" Details=[{"code":"InternalServerError","message":""}]

The tests now pass:

screenshot 2018-07-12 at 10 49 27

@tombuildsstuff tombuildsstuff added this to the 1.10.0 milestone Jul 12, 2018
tombuildsstuff
tombuildsstuff approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@tombuildsstuff tombuildsstuff merged commit 68df047 into hashicorp:master Jul 12, 2018
tombuildsstuff added a commit that referenced this pull request Jul 12, 2018
@tombuildsstuff
Updating to include #1546
165a5a5
@tombuildsstuff
Copy link
Contributor

hi @phekmat

Just to let you know that is now available in [v1.10 of the AzureRM Provider(https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.10.0/CHANGELOG.md#1100-july-21-2018) - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

torresdal added a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 25, 2018
@torresdal
Merge branch 'api-management' into api-management-api
2004c75 
* api-management:
  Updating to include hashicorp#1565
  resource/servicebus_subscription_rule: Fix the correlation_filter optional values (hashicorp#1565)
  Updating to include hashicorp#1563
  resouce/app_insights: Allow different application_type deployments (hashicorp#1563)
  VMSS: changed sku property from a set to list
  Update CHANGELOG.md to include hashicorp#1552
  Renamed azurerm_azuread_application.html.markdown to azuread_application.html.markdown
  New Data Source: `azurerm_azuread_application`
  VMSS: Updating the code samples to be valid. Fixes hashicorp#1539 (hashicorp#1549)
  Creation Data -> Creation Date (hashicorp#1548)
  Updating to include hashicorp#1546
  Workaround upstream issue in creating azureEndpoints in traffic manager (hashicorp#1546)
  Cleanup after v1.9.0 release
  v1.9.0
  Updating to include hashicorp#1269
  New Resource: `azurerm_azuread_application` (hashicorp#1269)
  Remove tags validate in preConfig of TestAccAzureRMKeyVault_update (hashicorp#1534)
  Updating to include hashicorp#1535
  `azurerm_key_vault_key` - handling the parent Key Vault being deleted (hashicorp#1535)
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/traffic-manager
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Unable to create azureEndpoints azurerm_traffic_manager_endpoint
2 participants
@phekmat @tombuildsstuff