-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource health to azurerm_monitor_activity_log_alert
#14917
Add resource health to azurerm_monitor_activity_log_alert
#14917
Conversation
internal/services/monitor/monitor_activity_log_alert_resource.go
Outdated
Show resolved
Hide resolved
internal/services/monitor/monitor_activity_log_alert_resource.go
Outdated
Show resolved
Hide resolved
@katbyte - comments resolved, ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tj-spyro - couple small comments on docs and some test failures:
------- Stdout: -------
=== RUN TestAccMonitorActivityLogAlert_ResourceHealth_basicAndUpdate
=== PAUSE TestAccMonitorActivityLogAlert_ResourceHealth_basicAndUpdate
=== CONT TestAccMonitorActivityLogAlert_ResourceHealth_basicAndUpdate
testcase.go:110: Step 1/6 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_monitor_activity_log_alert.test will be updated in-place
~ resource "azurerm_monitor_activity_log_alert" "test" {
id = "/subscriptions/*******/resourceGroups/acctestRG-220202220513688243/providers/Microsoft.Insights/activityLogAlerts/acctestActivityLogAlert-220202220513688243"
name = "acctestActivityLogAlert-220202220513688243"
tags = {}
# (4 unchanged attributes hidden)
~ criteria {
# (1 unchanged attribute hidden)
~ resource_health {
~ current = [
+ "Degraded",
+ "Unavailable",
]
~ previous = [
+ "Available",
+ "Unknown",
]
# (1 unchanged attribute hidden)
}
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccMonitorActivityLogAlert_ResourceHealth_basicAndUpdate (211.98s)
FAIL
22f512e
to
7be6628
Compare
@katbyte, sorry for the delay in getting the changes made. Should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tj-spyro - LGTM now 🚀
Add resource health to azurerm_monitor_activity_log_alert Fixes #9391
This functionality has been released in v2.97.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add resource health to
azurerm_monitor_activity_log_alert
Fixes #9391