Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-Feature-Request SQL Threat Detection Policy #1484

Closed
whytoe opened this issue Jul 3, 2018 · 11 comments · Fixed by #13048
Closed

New-Feature-Request SQL Threat Detection Policy #1484

whytoe opened this issue Jul 3, 2018 · 11 comments · Fixed by #13048
Labels
enhancement service/mssql Microsoft SQL Server
Milestone

Comments

@whytoe
Copy link
Contributor

whytoe commented Jul 3, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Enable the SQL Threat Detection feature when deploying SQL Servers in Platform as a Service

New or Affected Resource(s)

  • azurerm_sql_server

Potential Terraform Configuration

sql_threat_detection : "true"

References

The Azure API documentation
https://docs.microsoft.com/en-us/rest/api/sql/databasethreatdetectionpolicies/createorupdate

Go SDK does not appear to support it ( i couldnt find it)

  • #0000
@whytoe whytoe changed the title SQL Threat Detection Policy New-Feature-Request SQL Threat Detection Policy Jul 3, 2018
@tombuildsstuff
Copy link
Contributor

hey @whytoe

Thanks for opening this issue :)

Taking a quick look at this / some notes for whoever picks this up: this appears to be available in the Go SDK here: https://github.com/Azure/azure-sdk-for-go/blob/v17.4.0/services/sql/mgmt/2014-04-01/sql/databasethreatdetectionpolicies.go#L52 - and this would probably make sense nested under the azurerm_sql_server resource rather than as an independent resource.

Thanks!

@Lucretius
Copy link
Contributor

@tombuildsstuff just going through the issue backlog, looks like this one got resolved a while back and can be closed.

@andreas-schilling
Copy link

It's available on DB-Level, but not on server-level (which is recommended by Microsoft)

@MelleD
Copy link

MelleD commented May 7, 2019

Is there a time plan for this feature?

@techjacker
Copy link

techjacker commented May 29, 2019

Is there any plan to add this for Azure storage?

The go SDK doesn't seem to support it currently but it can be done via a direct call to the API:
https://docs.microsoft.com/en-us/rest/api/securitycenter/advancedthreatprotection/create

@tombuildsstuff
Copy link
Contributor

@techjacker I may be wrong, but that appears to be a separate (unrelated) service to the one in this issue? If so, would you mind opening a separate feature request for that? Thanks!

@techjacker
Copy link

@tombuildsstuff Sure I'll do this and add the link back to this thread when I'm done.

@techjacker
Copy link

@tombuildsstuff Sure I'll do this and add the link back to this thread when I'm done.

Created feature request here: #3670

@jonhoare
Copy link

jonhoare commented Mar 16, 2020

Are there any plans for this to be added to SQL Server Configuration?

favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Aug 18, 2021
```
$ TF_ACC=1 go test -v ./internal/services/sql -timeout=1000m -run='TestAccSqlServer_threatDetectionPolicy'
=== RUN   TestAccSqlServer_threatDetectionPolicy
=== PAUSE TestAccSqlServer_threatDetectionPolicy
=== CONT  TestAccSqlServer_threatDetectionPolicy
--- PASS: TestAccSqlServer_threatDetectionPolicy (316.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	318.103s
```

Fixes hashicorp#1484
@tombuildsstuff tombuildsstuff added this to the v2.73.0 milestone Aug 19, 2021
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants