allow postgres version 10.0 #1457
Conversation
There was a problem hiding this comment.
Hi @featheredtoast,
Thank you for this PR, it mostly LGTM. Could we get a todo comment and update the documentation?
Thanks
| @@ -122,6 +122,7 @@ func resourceArmPostgreSQLServer() *schema.Resource { | |||
| ValidateFunc: validation.StringInSlice([]string{ | |||
| string(postgresql.NineFullStopFive), | |||
| string(postgresql.NineFullStopSix), | |||
| "10.0", | |||
There was a problem hiding this comment.
Could we get a todo comment here mentioning switching it over to the enum once it is in the SDK?
|
OK done - Updated the docs, added the requested TODO comment. |
There was a problem hiding this comment.
Thanks for the updates! I forgot to mention adding a test, hope you don't' mind but i added it myself so we could include this in 1.8. LGTM now 👍
Also for future reference we don't update the chaneglog in the PR. That is a separate step we do after merge.
Thanks for the contribution!
|
No worries, just happy to have gotten this in quickly - thanks for fixing it up! ❤️ |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
We're attempting to get a Postgres 10 instance up through Terraform, but are unable to due to restrictive version checks.
This is a fix that adds support "10.0" as a valid version string until the azure go api adds a proper "10.0" enum.