Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres 10 support #2130

Closed
featheredtoast opened this issue Jun 26, 2018 · 6 comments
Closed

postgres 10 support #2130

featheredtoast opened this issue Jun 26, 2018 · 6 comments
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.

Comments

@featheredtoast
Copy link

Azure supports version 10 of Postgres, but currently this is not supported via this sdk. Please allow "10" as a valid postgres version parameter.

@vladbarosan
Copy link

Hi @featheredtoast the specs have not been updated to reflect that the new version is available. We will reach out to the service team for that.

Meanwhile, the underlying type of the ServerVersion is a string, can you try to just specify version 10.0 ?

@vladbarosan vladbarosan self-assigned this Jun 27, 2018
@featheredtoast
Copy link
Author

Hi @vladbarosan thanks for the quick response - I should note I'm trying to trace this issue through Terraform and it appears to be depending on the azure-sdk lib to determine valid input.

For reference, Terraform reports the following:

Error: azurerm_postgresql_server.server: expected version to be one of [9.5 9.6], got 10.0.

@vladbarosan
Copy link

vladbarosan commented Jun 27, 2018

@featheredtoast oh I see. Looking at it, https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_postgresql_server.go#L123 seems to validate strictly against the enum.

@tombuildsstuff do you if it happens to be a way to disable that validation function in the provider?

@featheredtoast
Copy link
Author

Thanks for pointing me in the right direction @vladbarosan - I've sent a PR to the Terraform provider plugin that allows a version specified as "10.0" here which should help alleviate things until enums are available: hashicorp/terraform-provider-azurerm#1457

@vladbarosan
Copy link

@featheredtoast this is now available in the latest branch. This will be present in our next minor release if no breaking change is coming .

https://github.com/Azure/azure-sdk-for-go/blob/latest/services/postgresql/mgmt/2017-12-01/postgresql/models.go#L125

@vladbarosan
Copy link

This is available in v18.1

@ghost ghost removed the fix-available label Jul 13, 2018
@RickWinter RickWinter added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

No branches or pull requests

3 participants