Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_workspace_key contain an argument with a typo and documentation not up-to-date #13864

Closed
desjardins-mcroy opened this issue Oct 22, 2021 · 2 comments · Fixed by #13881

Comments

@desjardins-mcroy
Copy link

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The argument customer_managed_key_name for the ressource azurerm_synapse_workspace_key seems to have a typo (cusomter_managed_key_name) . Also the documentation dosen't seem to be updated with the latest arguments for the resource.

Terraform (and AzureRM Provider) Version

Terraform v1.0.8
Provider registry.terraform.io/hashicorp/azurerm v2.82.0

Affected Resource(s)

azurerm_synapse_workspace_key

Terraform Configuration Files

resource "azurerm_synapse_workspace_key" "this" {
  active                              = true
  customer_managed_key_versionless_id = var.customer_managed_key_versionless_id
  synapse_workspace_id                = concat(azurerm_synapse_workspace.this.*.identity.0.principal_id, [""])[0]
  cusomter_managed_key_name = var.customer_managed_key_name
  depends_on                = [azurerm_role_assignment.this_kv]
}

Steps to Reproduce

NA

Important Factoids

  • I think the documentation here for the synapse_workspace_key should be named synapse_workspace_key instead of synapse_workspace_keys .
  • In the same documentation page, key_name should be changed to customer_managed_key_name (cusomter_managed_key_name) to reflect the proper argument.
  • The documentation here also doesn't reflect the use of the customer_managed_key block. reference .

References

keyName := d.Get("cusomter_managed_key_name").(string)

favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Oct 25, 2021
@favoretti favoretti self-assigned this Oct 25, 2021
katbyte pushed a commit that referenced this issue Oct 29, 2021
…` in favour of the correctly spelled `customer_managed_key_name` (#13881)

Co-authored-by: kt <[email protected]>
Fixes #13864
@katbyte katbyte added this to the v2.84.0 milestone Oct 29, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.