-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to enable vulnerability assessments for Azure Synapse SQL Pools #13276
Add capability to enable vulnerability assessments for Azure Synapse SQL Pools #13276
Conversation
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @owenfarrell. For the most part this looks good, just a few suggestions regarding the property names in the schema. Would also be good if the merge conflict could be resolved 🙂.
internal/services/synapse/synapse_sql_pool_security_alert_policy_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_sql_pool_vulnerability_assessment_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_workspace_security_alert_policy_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_workspace_security_alert_policy_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_sql_pool_security_alert_policy_resource.go
Outdated
Show resolved
Hide resolved
internal/services/synapse/synapse_workspace_security_alert_policy_resource.go
Outdated
Show resolved
Hide resolved
e27235c
to
0046903
Compare
Co-authored-by: stephybun <steph@hashicorp.com>
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
0046903
to
bdd4d1a
Compare
@stephybun - Okay, the schema changes ended up being a bit meatier than I expected. But I think I've got all the code and documentation updates done. I've rerun the acceptance tests and everything still passes. And I've updated all of the error messages to align with the pattern change you requested. Let me know if there's anything else! |
Thanks @owenfarrell, LGTM 🚀 |
This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Summary
This pull request adds support for managing vulnerability assessments for Synapse workspaces and Synapse workspace SQL pools. The implementation and the acceptance tests are largely derived from analogous implementations for SQL servers and SQL databases.
Vulnerability assessments are dependent on the definition of security alert policies, so this pull request includes the definition of those resources as well.
This PR likely conflicts in some common client/registration code with #12952, #13044, and/or #13179.
Output from acceptance testing: