Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low priority VM Scale Set support #1249

Closed
CoRfr opened this issue May 17, 2018 · 2 comments
Closed

Low priority VM Scale Set support #1249

CoRfr opened this issue May 17, 2018 · 2 comments
Labels
enhancement service/vmss Virtual Machine Scale Sets
Milestone

Comments

@CoRfr
Copy link
Contributor

CoRfr commented May 17, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

This feature is still in preview but it would be quite useful to have it supported in terraform.
https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority

New or Affected Resource(s)

  • azurerm_virtual_machine_scale_set

Potential Terraform Configuration

resource "azurerm_virtual_machine_scale_set" "scaleset" {
  name                = "autoscalewad"
  location            = "${azurerm_resource_group.rg.location}"
  resource_group_name = "${azurerm_resource_group.rg.name}"
  upgrade_policy_mode = "Manual"
  overprovision       = true
  depends_on          = ["azurerm_lb.lb", "azurerm_virtual_network.vnet"]
  priority            = "Low"

References

CoRfr pushed a commit to CoRfr/terraform-provider-azurerm that referenced this issue May 17, 2018
Purpose is to support low-priority VMs, which should partially
address hashicorp#1249.

This is simply adding a 'priority' parameter that can be set
to Low or Regular (=default).

The evictionPolicy is not supported yet as it was introduced
in a more recent version of the compute API (2018-04-01).

Cf https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority
@tombuildsstuff tombuildsstuff added service/vmss Virtual Machine Scale Sets enhancement labels May 17, 2018
CoRfr pushed a commit to CoRfr/terraform-provider-azurerm that referenced this issue May 22, 2018
Purpose is to support low-priority VMs, which should partially
address hashicorp#1249.

This is simply adding a 'priority' parameter that can be set
to Low or Regular (=default).

The evictionPolicy is not supported yet as it was introduced
in a more recent version of the compute API (2018-04-01).

Cf https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority
CoRfr pushed a commit to CoRfr/terraform-provider-azurerm that referenced this issue May 24, 2018
Purpose is to support low-priority VMs, which should partially
address hashicorp#1249.

This is simply adding a 'priority' parameter that can be set
to Low or Regular (=default).

The evictionPolicy is not supported yet as it was introduced
in a more recent version of the compute API (2018-04-01).

Cf https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority
@katbyte katbyte added this to the 1.6.0 milestone May 25, 2018
@katbyte
Copy link
Collaborator

katbyte commented May 25, 2018

Hey @CoRfr ,

Just wanted to let you know we have released v1.6.0 of the provider containing your PR for this issue 🙂

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets
Projects
None yet
Development

No branches or pull requests

3 participants