Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Log Analytics Workspace Sku (PerGB2018) #1078

Closed
MattMencel opened this issue Apr 5, 2018 · 8 comments · Fixed by #1079
Closed

New Log Analytics Workspace Sku (PerGB2018) #1078

MattMencel opened this issue Apr 5, 2018 · 8 comments · Fixed by #1079
Labels
bug service/oms upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR

Comments

@MattMencel
Copy link
Contributor

MattMencel commented Apr 5, 2018

Terraform Version

0.11.5

Affected Resource(s)

  • azurerm_log_analytics_workspace

Terraform Configuration Files

resource "azurerm_log_analytics_workspace" "law-demo" {
  name                = "demo-workspace-${random_id.workspace.hex}"
  location            = "${var.location}"
  resource_group_name = "${azurerm_resource_group.oms.name}"
  sku                 = "Free"
}

Debug Output

https://gist.github.com/MattMencel/bc48429af5d1021756a9eb44f649d8c2

Expected Behavior

Azure API accepts the Sku

Actual Behavior

Azure API rejected the Skus currently documented in the API.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply

Important Factoids

On April 3rd, 2018 Microsoft changed the pricing tiers for Log Analytics.

https://azure.microsoft.com/en-us/blog/introducing-a-new-way-to-purchase-azure-monitoring-services/

I did some research and was able to find the new Sku name, PerGB2018. This is not officially documented anywhere yet that I can find. I successfully tested deployment using the new Sku.

I believe the old Skus will still work if you have an older Azure subscription and have deployed Log Analytics services prior to April 3, 2018. I am unable to test this in my subscription.

References

#1079

@Jtaylorapps
Copy link

Found this same issue - seems terraform refuses to use the working SKU you provided.

Error: azurerm_log_analytics_workspace.test: expected sku to be one of [Free PerNode Premium Standalone Standard Unlimited], got PerGB2018

@MattMencel
Copy link
Contributor Author

@Jakexx360 It's in my PR. I'm running a local copy of my terraform-provider-azurerm fork.

#1079

I'm not sure, but it might be waiting on the PerGB2018 changes to appear in the Azure SDK.

@tombuildsstuff tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Apr 19, 2018
@tombuildsstuff
Copy link
Contributor

@metacpp whilst the Swaggers been fixed, would you be able to reach out to the service team about getting the API fixed here too? Due to this API change this service isn't usable - whereas other resources such as MySQL and Postgres will silently update the SKU as needed. Thanks!

@IronCore864
Copy link

If it's a dev env, as a temporary solution, you can put as "PerNode", which could at least create the cluster successfully.

@whytoe
Copy link
Contributor

whytoe commented Jun 14, 2018

@metacpp This should be resolved now as Terraform is detecting the API setting now

sku: "pergb2018" => "Standard" (forces new resource)

@katbyte
Copy link
Collaborator

katbyte commented Jun 14, 2018

Hi @whytoe,

I can't be entirely certain but it looks like from that snippet terraform is changing the sku from pergb2018 (the one it doesn't know about) to Standard (one it does)

@whytoe
Copy link
Contributor

whytoe commented Jun 14, 2018

@katbyte you are correct but the Azure API is still returning that value, I thought the upstream Microsoft tag related to the Azure API not having that functionality

This is also a link to have i changed my old Terraform OMS from free to pergb2018

https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/monitoring-usage-and-estimated-costs#new-pricing-model-and-operations-management-suite-subscription-entitlements

tombuildsstuff pushed a commit that referenced this issue Jun 18, 2018
)

* New Log Analytics Sku for `azurerm_log_analytics_workspace` (#1078)

* Migrating to use the new SKU's. Tests pass:

```
$ acctests azurerm TestAccAzureRMLogAnalyticsWorkspace_

=== RUN   TestAccAzureRMLogAnalyticsWorkspace_importRequiredOnly
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_importRequiredOnly (136.16s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_importRetentionInDaysComplete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_importRetentionInDaysComplete (74.59s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_requiredOnly
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_requiredOnly (129.72s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_retentionInDaysComplete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_retentionInDaysComplete (131.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	471.669s
```
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost unassigned metacpp Mar 30, 2020
@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/oms upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants