Skip to content

Commit

Permalink
Increasing timeout to fix dns issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@mbfrahry
mbfrahry committed Oct 25, 2017
1 parent d5fccc8 commit d9772b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion azurerm/resource_arm_key_vault.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func resourceArmKeyVaultCreate(d *schema.ResourceData, meta interface{}) error {
if d.IsNewResource() {
if props := read.Properties; props != nil {
if vault := props.VaultURI; vault != nil {
err := resource.Retry(30*time.Second, checkKeyVaultDNSIsAvailable(*vault))
err := resource.Retry(120*time.Second, checkKeyVaultDNSIsAvailable(*vault))
if err != nil {
return err
}
Expand Down

2 comments on commit d9772b1

@pixelicous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like this completely solved the issues..
I create keyvault and secrets, the secrets fail to get produced as the DNS entry for the keyvault is not ready yet.. posted an issue about this at #655

This started in the past week or so.

If we re run the same terraform, the secrets will get created, the dns is available

@pixelicous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check whether keyvault is ready should be with a DNS query, the problem is that you might query one DNS server while others are still not replicated. A timely based check is not sufficient here.. and is failing

Please sign in to comment.