azurerm_api_management_subscription - Support `allow_tracing proper…

…ty` (#7969)
hashicorp · Aug 28, 2020 · d813adc · d813adc
1 parent 4262285
commit d813adc
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 10 deletions.
diff --git a/azurerm/internal/services/apimanagement/api_management_subscription_resource.go b/azurerm/internal/services/apimanagement/api_management_subscription_resource.go
@@ -90,6 +90,12 @@ func resourceArmApiManagementSubscription() *schema.Resource {
 				Computed:  true,
 				Sensitive: true,
 			},
+
+			"allow_tracing": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  true,
+			},
 		},
 	}
 }
@@ -123,13 +129,15 @@ func resourceArmApiManagementSubscriptionCreateUpdate(d *schema.ResourceData, me
 	productId := d.Get("product_id").(string)
 	state := d.Get("state").(string)
 	userId := d.Get("user_id").(string)
+	allowTracing := d.Get("allow_tracing").(bool)
 
 	params := apimanagement.SubscriptionCreateParameters{
 		SubscriptionCreateParameterProperties: &apimanagement.SubscriptionCreateParameterProperties{
-			DisplayName: utils.String(displayName),
-			Scope:       utils.String(productId),
-			State:       apimanagement.SubscriptionState(state),
-			OwnerID:     utils.String(userId),
+			DisplayName:  utils.String(displayName),
+			Scope:        utils.String(productId),
+			State:        apimanagement.SubscriptionState(state),
+			OwnerID:      utils.String(userId),
+			AllowTracing: utils.Bool(allowTracing),
 		},
 	}
 
@@ -190,6 +198,7 @@ func resourceArmApiManagementSubscriptionRead(d *schema.ResourceData, meta inter
 		d.Set("state", string(props.State))
 		d.Set("product_id", props.Scope)
 		d.Set("user_id", props.OwnerID)
+		d.Set("allow_tracing", props.AllowTracing)
 	}
 
 	// Primary and secondary keys must be got from this additional api

diff --git a/azurerm/internal/services/apimanagement/tests/api_management_subscription_resource_test.go b/azurerm/internal/services/apimanagement/tests/api_management_subscription_resource_test.go
@@ -23,6 +23,7 @@ func TestAccAzureRMAPIManagementSubscription_basic(t *testing.T) {
 				Config: testAccAzureRMAPIManagementSubscription_basic(data),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
+					resource.TestCheckResourceAttr(data.ResourceName, "allow_tracing", "true"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
@@ -64,36 +65,44 @@ func TestAccAzureRMAPIManagementSubscription_update(t *testing.T) {
 		CheckDestroy: testCheckAzureRMAPIManagementSubscriptionDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccAzureRMAPIManagementSubscription_update(data, "submitted"),
+				Config: testAccAzureRMAPIManagementSubscription_update(data, "submitted", "true"),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "state", "submitted"),
+					resource.TestCheckResourceAttr(data.ResourceName, "allow_tracing", "true"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
 				),
 			},
 			{
-				Config: testAccAzureRMAPIManagementSubscription_update(data, "active"),
+				Config: testAccAzureRMAPIManagementSubscription_update(data, "active", "true"),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "state", "active"),
 				),
 			},
 			{
-				Config: testAccAzureRMAPIManagementSubscription_update(data, "suspended"),
+				Config: testAccAzureRMAPIManagementSubscription_update(data, "suspended", "true"),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "state", "suspended"),
 				),
 			},
 			{
-				Config: testAccAzureRMAPIManagementSubscription_update(data, "cancelled"),
+				Config: testAccAzureRMAPIManagementSubscription_update(data, "cancelled", "true"),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "state", "cancelled"),
 				),
 			},
+			{
+				Config: testAccAzureRMAPIManagementSubscription_update(data, "active", "false"),
+				Check: resource.ComposeTestCheckFunc(
+					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
+					resource.TestCheckResourceAttr(data.ResourceName, "allow_tracing", "false"),
+				),
+			},
 		},
 	})
 }
@@ -111,6 +120,7 @@ func TestAccAzureRMAPIManagementSubscription_complete(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "state", "active"),
+					resource.TestCheckResourceAttr(data.ResourceName, "allow_tracing", "false"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
 					resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
@@ -202,7 +212,7 @@ resource "azurerm_api_management_subscription" "import" {
 `, template)
 }
 
-func testAccAzureRMAPIManagementSubscription_update(data acceptance.TestData, state string) string {
+func testAccAzureRMAPIManagementSubscription_update(data acceptance.TestData, state string, allow_tracing string) string {
 	template := testAccAzureRMAPIManagementSubscription_template(data)
 	return fmt.Sprintf(`
 %s
@@ -214,8 +224,9 @@ resource "azurerm_api_management_subscription" "test" {
   product_id          = azurerm_api_management_product.test.id
   display_name        = "Butter Parser API Enterprise Edition"
   state               = "%s"
+  allow_tracing       = "%s"
 }
-`, template, state)
+`, template, state, allow_tracing)
 }
 
 func testAccAzureRMAPIManagementSubscription_complete(data acceptance.TestData) string {
@@ -230,6 +241,7 @@ resource "azurerm_api_management_subscription" "test" {
   product_id          = azurerm_api_management_product.test.id
   display_name        = "Butter Parser API Enterprise Edition"
   state               = "active"
+  allow_tracing       = "false"
 }
 `, template)
 }

diff --git a/website/docs/r/api_management_subscription.html.markdown b/website/docs/r/api_management_subscription.html.markdown
@@ -61,6 +61,8 @@ The following arguments are supported:
 
 * `subscription_id` - (Optional) An Identifier which should used as the ID of this Subscription. If not specified a new Subscription ID will be generated. Changing this forces a new resource to be created.
 
+* `allow_tracing` - (Optional) Determines whether tracing can be enabled.  Defaults to `true`.
+
 ## Attributes Reference
 
 In addition to all arguments above, the following attributes are exported: