Skip to content

Commit

Permalink
data.azurerm_sentinel_alert_rule_template: Set custom ID rather tha…
Browse files Browse the repository at this point in the history 
…n using ID returned from API (#19580)
  • Loading branch information
@mbfrahry
mbfrahry authored Dec 7, 2022
1 parent dd5689a commit be64320
Showing 1 changed file with 13 additions and 47 deletions.
60 changes: 13 additions & 47 deletions internal/services/sentinel/sentinel_alert_rule_template_data_source.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package sentinel

import (
"context"
"errors"
"fmt"
"time"

Expand Down Expand Up @@ -146,6 +145,7 @@ func dataSourceSentinelAlertRuleTemplate() *pluginsdk.Resource {

func dataSourceSentinelAlertRuleTemplateRead(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).Sentinel.AlertRuleTemplatesClient
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
ctx, cancel := timeouts.ForRead(meta.(*clients.Client).StopContext, d)
defer cancel()

Expand All @@ -155,6 +155,7 @@ func dataSourceSentinelAlertRuleTemplateRead(d *pluginsdk.ResourceData, meta int
if err != nil {
return err
}
id := parse.NewSentinelAlertRuleTemplateID(subscriptionId, workspaceID.ResourceGroupName, workspaceID.WorkspaceName, name)

// Either "name" or "display_name" must have been specified, constrained by the pluginsdk.
var resp securityinsight.BasicAlertRuleTemplate
Expand All @@ -172,21 +173,21 @@ func dataSourceSentinelAlertRuleTemplateRead(d *pluginsdk.ResourceData, meta int

switch template := resp.(type) {
case securityinsight.MLBehaviorAnalyticsAlertRuleTemplate:
err = setForMLBehaviorAnalyticsAlertRuleTemplate(d, &template)
err = setForMLBehaviorAnalyticsAlertRuleTemplate(d, id, &template)
case securityinsight.FusionAlertRuleTemplate:
err = setForFusionAlertRuleTemplate(d, &template)
err = setForFusionAlertRuleTemplate(d, id, &template)
case securityinsight.MicrosoftSecurityIncidentCreationAlertRuleTemplate:
err = setForMsSecurityIncidentAlertRuleTemplate(d, &template)
err = setForMsSecurityIncidentAlertRuleTemplate(d, id, &template)
case securityinsight.ScheduledAlertRuleTemplate:
err = setForScheduledAlertRuleTemplate(d, &template)
err = setForScheduledAlertRuleTemplate(d, id, &template)
case securityinsight.NrtAlertRuleTemplate:
err = setForNrtAlertRuleTemplate(d, &template)
err = setForNrtAlertRuleTemplate(d, id, &template)
default:
return fmt.Errorf("unknown template type of Sentinel Alert Rule Template %q (Workspace %q / Resource Group %q) ID", nameToLog, workspaceID.WorkspaceName, workspaceID.ResourceGroupName)
}

if err != nil {
return fmt.Errorf("setting ResourceData for Sentinel Alert Rule Template %q (Workspace %q / Resource Group %q) ID", nameToLog, workspaceID.WorkspaceName, workspaceID.ResourceGroupName)
return fmt.Errorf("setting ResourceData for Sentinel Alert Rule Template %q (Workspace %q / Resource Group %q) ID: %+v", nameToLog, workspaceID.WorkspaceName, workspaceID.ResourceGroupName, err)
}

return nil
Expand Down Expand Up @@ -245,70 +246,35 @@ func getAlertRuleTemplateByDisplayName(ctx context.Context, client *securityinsi
return results[0], nil
}

func setForScheduledAlertRuleTemplate(d *pluginsdk.ResourceData, template *securityinsight.ScheduledAlertRuleTemplate) error {
if template.ID == nil || *template.ID == "" {
return errors.New("empty or nil ID")
}
id, err := parse.SentinelAlertRuleTemplateID(*template.ID)
if err != nil {
return err
}
func setForScheduledAlertRuleTemplate(d *pluginsdk.ResourceData, id parse.SentinelAlertRuleTemplateId, template *securityinsight.ScheduledAlertRuleTemplate) error {
d.SetId(id.ID())
d.Set("name", template.Name)
d.Set("display_name", template.DisplayName)
return d.Set("scheduled_template", flattenScheduledAlertRuleTemplate(template.ScheduledAlertRuleTemplateProperties))
}

func setForNrtAlertRuleTemplate(d *pluginsdk.ResourceData, template *securityinsight.NrtAlertRuleTemplate) error {
if template.ID == nil || *template.ID == "" {
return errors.New("empty or nil ID")
}
id, err := parse.SentinelAlertRuleTemplateID(*template.ID)
if err != nil {
return err
}
func setForNrtAlertRuleTemplate(d *pluginsdk.ResourceData, id parse.SentinelAlertRuleTemplateId, template *securityinsight.NrtAlertRuleTemplate) error {
d.SetId(id.ID())
d.Set("name", template.Name)
d.Set("display_name", template.DisplayName)
return d.Set("nrt_template", flattenNrtAlertRuleTemplate(template.NrtAlertRuleTemplateProperties))
}

func setForMsSecurityIncidentAlertRuleTemplate(d *pluginsdk.ResourceData, template *securityinsight.MicrosoftSecurityIncidentCreationAlertRuleTemplate) error {
if template.ID == nil || *template.ID == "" {
return errors.New("empty or nil ID")
}
id, err := parse.SentinelAlertRuleTemplateID(*template.ID)
if err != nil {
return err
}
func setForMsSecurityIncidentAlertRuleTemplate(d *pluginsdk.ResourceData, id parse.SentinelAlertRuleTemplateId, template *securityinsight.MicrosoftSecurityIncidentCreationAlertRuleTemplate) error {
d.SetId(id.ID())
d.Set("name", template.Name)
d.Set("display_name", template.DisplayName)
return d.Set("security_incident_template", flattenMsSecurityIncidentAlertRuleTemplate(template.MicrosoftSecurityIncidentCreationAlertRuleTemplateProperties))
}

func setForFusionAlertRuleTemplate(d *pluginsdk.ResourceData, template *securityinsight.FusionAlertRuleTemplate) error {
if template.ID == nil || *template.ID == "" {
return errors.New("empty or nil ID")
}
id, err := parse.SentinelAlertRuleTemplateID(*template.ID)
if err != nil {
return err
}
func setForFusionAlertRuleTemplate(d *pluginsdk.ResourceData, id parse.SentinelAlertRuleTemplateId, template *securityinsight.FusionAlertRuleTemplate) error {
d.SetId(id.ID())
d.Set("name", template.Name)
d.Set("display_name", template.DisplayName)
return nil
}

func setForMLBehaviorAnalyticsAlertRuleTemplate(d *pluginsdk.ResourceData, template *securityinsight.MLBehaviorAnalyticsAlertRuleTemplate) error {
if template.ID == nil || *template.ID == "" {
return errors.New("empty or nil ID")
}
id, err := parse.SentinelAlertRuleTemplateID(*template.ID)
if err != nil {
return err
}
func setForMLBehaviorAnalyticsAlertRuleTemplate(d *pluginsdk.ResourceData, id parse.SentinelAlertRuleTemplateId, template *securityinsight.MLBehaviorAnalyticsAlertRuleTemplate) error {
d.SetId(id.ID())
d.Set("name", template.Name)
d.Set("display_name", template.DisplayName)
Expand Down

0 comments on commit be64320

Please sign in to comment.