Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sreallymatt committed Dec 10, 2024
1 parent d5db7ef commit b8a82d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contributing/topics/guide-breaking-changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ The following example follows a fictional resource that will have the following
},
}
if !features.FivePointOhBeta {
if !features.FivePointOhBeta() {
args["enable_scaling"] = &pluginsdk.Schema{
Type: pluginsdk.TypeBool,
Optional: true,
Expand Down Expand Up @@ -336,7 +336,7 @@ Terraform will perform the following actions:
Plan: 0 to add, 1 to change, 0 to destroy.
```

This is a breaking change as Terraform should not trigger a plan between minor version upgrades. Instead, what we can do is add a TODO next to the `Default` tag to update the default value in the next major version of the provider or mark the field as Required if that default value is going to continue to change in the future:
This is a breaking change as Terraform should not trigger a plan between minor version upgrades. Instead, what we can do is use the major release feature flag as shown in the example below or mark the field as Required if that default value is going to continue to change in the future:

```go
func (r SparkResource) Arguments() map[string]*pluginsdk.Schema{
Expand Down

0 comments on commit b8a82d2

Please sign in to comment.