Feature: azurem_application_insights add support for `retention_in_…

…days` (#5457)
hashicorp · Jan 22, 2020 · 9313155 · 9313155
1 parent 72e65fa
commit 9313155
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 0 deletions.
diff --git a/azurerm/internal/services/applicationinsights/data_source_application_insights.go b/azurerm/internal/services/applicationinsights/data_source_application_insights.go
@@ -50,6 +50,11 @@ func dataSourceArmApplicationInsights() *schema.Resource {
 				Computed: true,
 			},
 
+			"retention_in_days": {
+				Type:     schema.TypeInt,
+				Computed: true,
+			},
+
 			"tags": {
 				Type:     schema.TypeMap,
 				Computed: true,
@@ -83,5 +88,8 @@ func dataSourceArmApplicationInsightsRead(d *schema.ResourceData, meta interface
 	d.Set("location", resp.Location)
 	d.Set("app_id", resp.AppID)
 	d.Set("application_type", resp.ApplicationType)
+	if v := resp.RetentionInDays; v != nil {
+		d.Set("retention_in_days", v)
+	}
 	return tags.FlattenAndSet(d, resp.Tags)
 }
diff --git a/azurerm/internal/services/applicationinsights/resource_arm_application_insights.go b/azurerm/internal/services/applicationinsights/resource_arm_application_insights.go
@@ -64,6 +64,22 @@ func resourceArmApplicationInsights() *schema.Resource {
 				}, true),
 			},
 
+			"retention_in_days": {
+				Type:     schema.TypeInt,
+				Optional: true,
+				ValidateFunc: validation.IntInSlice([]int{
+					30,
+					60,
+					90,
+					120,
+					180,
+					270,
+					365,
+					550,
+					730,
+				}),
+			},
+
 			"sampling_percentage": {
 				Type:         schema.TypeFloat,
 				Optional:     true,
@@ -121,6 +137,10 @@ func resourceArmApplicationInsightsCreateUpdate(d *schema.ResourceData, meta int
 		SamplingPercentage: samplingPercentage,
 	}
 
+	if v, ok := d.GetOk("retention_in_days"); ok {
+		applicationInsightsComponentProperties.RetentionInDays = utils.Int32(int32(v.(int)))
+	}
+
 	insightProperties := insights.ApplicationInsightsComponent{
 		Name:                                   &name,
 		Location:                               &location,
@@ -187,6 +207,9 @@ func resourceArmApplicationInsightsRead(d *schema.ResourceData, meta interface{}
 		d.Set("app_id", props.AppID)
 		d.Set("instrumentation_key", props.InstrumentationKey)
 		d.Set("sampling_percentage", props.SamplingPercentage)
+		if v := props.RetentionInDays; v != nil {
+			d.Set("retention_in_days", v)
+		}
 	}
 
 	return tags.FlattenAndSet(d, resp.Tags)

diff --git a/...erm/internal/services/applicationinsights/tests/resource_arm_application_insights_test.go b/...erm/internal/services/applicationinsights/tests/resource_arm_application_insights_test.go
@@ -248,6 +248,7 @@ func TestAccAzureRMApplicationInsights_complete(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMApplicationInsightsExists(data.ResourceName),
 					resource.TestCheckResourceAttr(data.ResourceName, "application_type", "web"),
+					resource.TestCheckResourceAttr(data.ResourceName, "retention_in_days", "120"),
 					resource.TestCheckResourceAttr(data.ResourceName, "sampling_percentage", "50"),
 					resource.TestCheckResourceAttr(data.ResourceName, "tags.%", "1"),
 					resource.TestCheckResourceAttr(data.ResourceName, "tags.Hello", "World"),
@@ -300,6 +301,7 @@ resource "azurerm_application_insights" "test" {
   location            = "${azurerm_resource_group.test.location}"
   resource_group_name = "${azurerm_resource_group.test.name}"
   application_type    = "%s"
+  retention_in_days   = 120
   sampling_percentage = 50
 
   tags = {

diff --git a/website/docs/d/application_insights.html.markdown b/website/docs/d/application_insights.html.markdown
@@ -35,4 +35,5 @@ output "application_insights_instrumentation_key" {
 * `application_type` - The type of the component.
 * `instrumentation_key` - The instrumentation key of the Application Insights component.
 * `location` - The Azure location where the component exists.
+* `retention_in_days` - The retention period in days.
 * `tags` - Tags applied to the component.
diff --git a/website/docs/r/application_insights.html.markdown b/website/docs/r/application_insights.html.markdown
@@ -48,6 +48,8 @@ The following arguments are supported:
 
 * `application_type` - (Required) Specifies the type of Application Insights to create. Valid values are `ios` for _iOS_, `java` for _Java web_, `MobileCenter` for _App Center_, `Node.JS` for _Node.js_, `other` for _General_, `phone` for _Windows Phone_, `store` for _Windows Store_ and `web` for _ASP.NET_. Please note these values are case sensitive; unmatched values are treated as _ASP.NET_ by Azure. Changing this forces a new resource to be created.
 
+* `retention_in_days` - (Optional) Specifies the retention period in days. Possible values are `30`, `60`, `90`, `120`, `180`, `270`, `365`, `550` or `730`.
+
 * `sampling_percentage` - (Optional) Specifies the percentage of the data produced by the monitored application that is sampled for Application Insights telemetry.
 
 * `tags` - (Optional) A mapping of tags to assign to the resource.