#24910: capturing and returning error as per review

hashicorp · Feb 16, 2024 · 8b56252 · 8b56252
1 parent aa15067
commit 8b56252
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/services/firewall/firewall_resource.go b/internal/services/firewall/firewall_resource.go
@@ -537,7 +537,10 @@ func resourceFirewallDelete(d *pluginsdk.ResourceData, meta interface{}) error {
 		}
 
 		if read.Model.Properties != nil && read.Model.Properties.FirewallPolicy != nil && read.Model.Properties.FirewallPolicy.Id != nil {
-			id, _ := firewallpolicies.ParseFirewallPolicyIDInsensitively(*read.Model.Properties.FirewallPolicy.Id)
+			id, err := firewallpolicies.ParseFirewallPolicyIDInsensitively(*read.Model.Properties.FirewallPolicy.Id)
+			if err != nil {
+				return err
+			}
 			locks.ByName(id.FirewallPolicyName, AzureFirewallPolicyResourceName)
 			defer locks.UnlockByName(id.FirewallPolicyName, AzureFirewallPolicyResourceName)
 		}