use createThenPoll; fix error message; fix doc

internal/services/azurestackhci/stack_hci_logical_network_resource.go

@@ -240,17 +240,12 @@ func (r StackHCILogicalNetworkResource) Create() sdk.ResourceFunc {
 				},
 			}
 
-			future, err := client.CreateOrUpdate(ctx, id, payload)
-			if err != nil {
+			if err := client.CreateOrUpdateThenPoll(ctx, id, payload); err != nil {
 				return fmt.Errorf("performing create %s: %+v", id, err)
 			}
 
 			metadata.SetID(id)
 
-			if err := future.Poller.PollUntilDone(ctx); err != nil {
-				return fmt.Errorf("polling after create %s: %+v", id, err)
-			}
-
 			return nil
 		},
 	}
@@ -332,7 +327,7 @@ func (r StackHCILogicalNetworkResource) Update() sdk.ResourceFunc {
 
 			parameters := resp.Model
 			if parameters == nil {
-				return fmt.Errorf("retrieving %s: model was nil", *id)
+				return fmt.Errorf("retrieving %s: `model` was nil", *id)
 			}
 
 			if metadata.ResourceData.HasChange("tags") {

internal/services/azurestackhci/stack_hci_logical_network_resource_test.go

@@ -6,13 +6,12 @@ import (
 	"os"
 	"testing"
 
-	"github.com/hashicorp/go-azure-helpers/lang/response"
+	"github.com/hashicorp/go-azure-helpers/lang/pointer"
 	"github.com/hashicorp/go-azure-sdk/resource-manager/azurestackhci/2024-01-01/logicalnetworks"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
-	"github.com/hashicorp/terraform-provider-azurerm/utils"
 )
 
 type StackHCILogicalNetworkResource struct{}
@@ -28,7 +27,7 @@ func TestAccStackHCILogicalNetwork_dynamic(t *testing.T) {
 	r := StackHCILogicalNetworkResource{}
 
 	if os.Getenv(customLocationIdEnv) == "" {
-		t.Skipf("skip the test as one or more of below environment variables are not specified: %q", customLocationIdEnv)
+		t.Skipf("skipping since %q has not been specified", customLocationIdEnv)
 	}
 
 	data.ResourceTest(t, r, []acceptance.TestStep{
@@ -47,7 +46,7 @@ func TestAccStackHCILogicalNetwork_update(t *testing.T) {
 	r := StackHCILogicalNetworkResource{}
 
 	if os.Getenv(customLocationIdEnv) == "" {
-		t.Skipf("skip the test as one or more of below environment variables are not specified: %q", customLocationIdEnv)
+		t.Skipf("skipping since %q has not been specified", customLocationIdEnv)
 	}
 
 	data.ResourceTest(t, r, []acceptance.TestStep{
@@ -121,14 +120,10 @@ func (r StackHCILogicalNetworkResource) Exists(ctx context.Context, client *clie
 
 	resp, err := clusterClient.Get(ctx, *id)
 	if err != nil {
-		if response.WasNotFound(resp.HttpResponse) {
-			return utils.Bool(false), nil
-		}
-
 		return nil, fmt.Errorf("retrieving %s: %+v", *id, err)
 	}
 
-	return utils.Bool(resp.Model != nil), nil
+	return pointer.To(resp.Model != nil), nil
 }
 
 func (r StackHCILogicalNetworkResource) dynamic(data acceptance.TestData) string {

website/docs/r/stack_hci_logical_network.html.markdown

@@ -55,7 +55,7 @@ The following arguments are supported:
 
 * `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Logical Network should exist. Changing this forces a new resource to be created.
 
-* `virtual_switch_name` - (Required) The name of the virtual switch on the cluster used to associate with the Azure Stack HCI Logical Network. Possible switch name can be retrieved following the [Azure documents](https://learn.microsoft.com/azure-stack/hci/manage/create-logical-networks?tabs=azurecli#prerequisites). Changing this forces a new resource to be created.
+* `virtual_switch_name` - (Required) The name of the virtual switch on the cluster used to associate with the Azure Stack HCI Logical Network. Possible switch names can be retrieved by following this [Azure guide](https://learn.microsoft.com/azure-stack/hci/manage/create-logical-networks?tabs=azurecli#prerequisites). Changing this forces a new resource to be created.
 
 * `subnet` - (Required) A `subnet` block as defined below. Changing this forces a new resource to be created.
 
@@ -93,7 +93,7 @@ A `subnet` block supports the following:
 
 * `route` - (Optional) One or more `route` block as defined above. Changing this forces a new resource to be created.
 
-* `vlan_id` - (Optional) VLAN ID for the Logical Network. Changing this forces a new resource to be created.
+* `vlan_id` - (Optional) The VLAN ID for the Logical Network. Changing this forces a new resource to be created.
 
 ## Attributes Reference