Skip to content

Commit

Permalink
New Data Source: azurerm_container_registry (#1642)
Browse files Browse the repository at this point in the history
* Add 'azurerm_container_image' data source

* Add 'azurerm_container_image' documentation

* Fix data source implementation and test

* Fix datasource docs

* Add link to datasource docs

* Fixes in data source

* Remove unused Schema fields
* Return error if resource is not found

* Ensuring the data source exists, rather than the resource
  • Loading branch information
schoren authored and tombuildsstuff committed Jul 25, 2018
1 parent 2c216b1 commit 2098ef3
Show file tree
Hide file tree
Showing 5 changed files with 207 additions and 0 deletions.
104 changes: 104 additions & 0 deletions azurerm/data_source_arm_container_registry.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
package azurerm

import (
"fmt"

"github.com/hashicorp/terraform/helper/schema"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
)

func dataSourceArmContainerRegistry() *schema.Resource {
return &schema.Resource{
Read: dataSourceArmContainerRegistryRead,

Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validateAzureRMContainerRegistryName,
},

"resource_group_name": resourceGroupNameForDataSourceSchema(),
"location": locationForDataSourceSchema(),
"admin_enabled": {
Type: schema.TypeBool,
Computed: true,
},
"admin_password": {
Type: schema.TypeString,
Computed: true,
},
"admin_username": {
Type: schema.TypeString,
Computed: true,
},
"login_server": {
Type: schema.TypeString,
Computed: true,
},
"sku": {
Type: schema.TypeString,
Computed: true,
},
"storage_account_id": {
Type: schema.TypeString,
Computed: true,
},
},
}
}

func dataSourceArmContainerRegistryRead(d *schema.ResourceData, meta interface{}) error {
client := meta.(*ArmClient).containerRegistryClient
ctx := meta.(*ArmClient).StopContext

name := d.Get("name").(string)
resourceGroup := d.Get("resource_group_name").(string)

resp, err := client.Get(ctx, resourceGroup, name)
if err != nil {
if utils.ResponseWasNotFound(resp.Response) {
return fmt.Errorf("Container Registry %q was not found in Resource Group %q", name, resourceGroup)
}

return fmt.Errorf("Error making Read request on Azure Container Registry %q (Resource Group %q): %+v", name, resourceGroup, err)
}

d.SetId(*resp.ID)
d.Set("name", resp.Name)
d.Set("resource_group_name", resourceGroup)
if location := resp.Location; location != nil {
d.Set("location", azureRMNormalizeLocation(*location))
}
d.Set("admin_enabled", resp.AdminUserEnabled)
d.Set("login_server", resp.LoginServer)

if sku := resp.Sku; sku != nil {
d.Set("sku", string(sku.Tier))
}

if account := resp.StorageAccount; account != nil {
d.Set("storage_account_id", account.ID)
}

if *resp.AdminUserEnabled {
credsResp, err := client.ListCredentials(ctx, resourceGroup, name)
if err != nil {
return fmt.Errorf("Error making Read request on Azure Container Registry %s for Credentials: %s", name, err)
}

d.Set("admin_username", credsResp.Username)
for _, v := range *credsResp.Passwords {
d.Set("admin_password", v.Value)
break
}
} else {
d.Set("admin_username", "")
d.Set("admin_password", "")
}

flattenAndSetTags(d, resp.Tags)

return nil
}
46 changes: 46 additions & 0 deletions azurerm/data_source_arm_container_registry_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package azurerm

import (
"fmt"
"testing"

"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource"
)

func TestAccDataSourceAzureRMContainerRegistry_basic(t *testing.T) {
ri := acctest.RandInt()
config := testAccDataSourceAzureRMContainerRegistry_basic(ri)

dataSourceName := "data.azurerm_container_registry.test"

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testCheckAzureRMContainerRegistryDestroy,
Steps: []resource.TestStep{
{
Config: config,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrSet(dataSourceName, "name"),
resource.TestCheckResourceAttrSet(dataSourceName, "resource_group_name"),
resource.TestCheckResourceAttrSet(dataSourceName, "location"),
resource.TestCheckResourceAttrSet(dataSourceName, "admin_enabled"),
resource.TestCheckResourceAttrSet(dataSourceName, "login_server"),
),
},
},
})
}

func testAccDataSourceAzureRMContainerRegistry_basic(rInt int) string {
resource := testAccAzureRMContainerRegistry_basicManaged(rInt, testLocation(), "Basic")
return fmt.Sprintf(`
%s
data "azurerm_container_registry" "test" {
name = "${azurerm_container_registry.test.name}"
resource_group_name = "${azurerm_container_registry.test.resource_group_name}"
}
`, resource)
}
1 change: 1 addition & 0 deletions azurerm/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func Provider() terraform.ResourceProvider {
"azurerm_cdn_profile": dataSourceArmCdnProfile(),
"azurerm_client_config": dataSourceArmClientConfig(),
"azurerm_cosmosdb_account": dataSourceArmCosmosDBAccount(),
"azurerm_container_registry": dataSourceArmContainerRegistry(),
"azurerm_data_lake_store": dataSourceArmDataLakeStoreAccount(),
"azurerm_dns_zone": dataSourceArmDnsZone(),
"azurerm_eventhub_namespace": dataSourceEventHubNamespace(),
Expand Down
4 changes: 4 additions & 0 deletions website/azurerm.erb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@
<a href="/docs/providers/azurerm/d/client_config.html">azurerm_client_config</a>
</li>

<li<%= sidebar_current("docs-azurerm-datasource-container-registry") %>>
<a href="/docs/providers/azurerm/d/container_registry.html">azurerm_container_registry</a>
</li>

<li<%= sidebar_current("docs-azurerm-cosmosdb-account") %>>
<a href="/docs/providers/azurerm/d/cosmosdb_account.html">azurerm_cosmosdb_account</a>
</li>
Expand Down
52 changes: 52 additions & 0 deletions website/docs/d/container_registry.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
layout: "azurerm"
page_title: "Azure Resource Manager: azurerm_container_registry"
sidebar_current: "docs-azurerm-datasource-container-registry"
description: |-
Get information about an Container Registry
---

# Data Source: azurerm_container_registry

Use this data source to access information about a Container Registry

## Example Usage

```hcl
data "azurerm_container_registry" "test" {
name = "testacr"
resource_group_name = "test"
}
output "login_server" {
value = "${data.azurerm_container_registry.test.login_server}"
}
```

## Argument Reference

* `name` - (Required) The name of the Container Registry.
* `resource_group_name` - (Required) The Name of the Resource Group where this Container Registry exists.

## Attributes Reference

The following attributes are exported:

* `id` - The Container Registry ID.

* `login_server` - The URL that can be used to log into the container registry.

* `admin_username` - The Username associated with the Container Registry Admin account - if the admin account is enabled.

* `admin_password` - The Password associated with the Container Registry Admin account - if the admin account is enabled.

* `location` - The Azure Region in which this Container Registry exists.

* `admin_enabled` - Is the Administrator account enabled for this Container Registry.

* `sku` - The SKU of this Container Registry, such as `Basic`.

* `storage_account_id` - The ID of the Storage Account used for this Container Registry. This is only returned for `Classic` SKU's.

* `tags` - A map of tags assigned to the Container Registry.

0 comments on commit 2098ef3

Please sign in to comment.