Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resources for Claims Mapping Policy Management #766

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

manicminer
Copy link
Contributor

This replaces #733 post-review and fixup, as I'm unable to push to that fork.


Originally opened by @computeracer

Adds support for the claims mapping policy and claims mapping policy assignment resources so these can be
managed with Terraform. This depends on the hamilton sdk support being merged first and then this branch can be updated with the correct vendor dependencies.

Related to:

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

computeracer and others added 4 commits April 8, 2022 02:15
Adds support for the claims mapping policy resource so these can be
managed with Terraform.

Related to:
- manicminer/hamilton#147
- #644
- https://docs.microsoft.com/en-us/graph/api/resources/claimsmappingpolicy?view=graph-rest-1.0
Adds support for the claims mapping policy assignment resource so
claims mapping policies can be assigned to a service principle
with Terraform.

Related to:
- manicminer/hamilton#147
- #644
- https://docs.microsoft.com/en-us/graph/api/serviceprincipal-post-claimsmappingpolicies?view=graph-rest-1.0&tabs=http
- Remove `description` property as the API doesn't allow it to be set
- Move `azuread_claims_mapping_policy` into new package `Policies`
- Update and tidy docs
- Fix up ID parsing for policy assignments
@manicminer manicminer force-pushed the r/claims-mapping-policy branch from 6a668ef to 1c163dd Compare April 8, 2022 01:16
@manicminer
Copy link
Contributor Author

Rebased onto main for build fixes

@manicminer manicminer merged commit f4e0ecf into main Apr 8, 2022
@manicminer manicminer deleted the r/claims-mapping-policy branch April 8, 2022 01:19
manicminer added a commit that referenced this pull request Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v2.20.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants