azuread_application: support the features block and the tags property
#630
Conversation
|
Test results
|
There was a problem hiding this comment.
Thanks @manicminer - overall looks good and i have some questions of schema
| @@ -214,6 +215,40 @@ func applicationDataSource() *schema.Resource { | |||
| Computed: true, | |||
| }, | |||
|
|
|||
| "features": { | |||
There was a problem hiding this comment.
should we be explicit and call this
| "features": { | |
| "tags_features": { |
or
| "features": { | |
| "tag_enabled_features": { |
docs/resources/application.md
Outdated
| @@ -162,6 +167,7 @@ The following arguments are supported: | |||
| * `device_only_auth_enabled` - (Optional) Specifies whether this application supports device authentication without a user. Defaults to `false`. | |||
| * `display_name` - (Required) The display name for the application. | |||
| * `fallback_public_client_enabled` - (Optional) Specifies whether the application is a public client. Appropriate for apps using token grant flows that don't use a redirect URI. Defaults to `false`. | |||
| * `features` - (Optional) A `features` block as described below. Cannot be used together with the `tags` property. Features applied to this application will propagate to, and supplement any features/tags configured for, a linked service principal. | |||
There was a problem hiding this comment.
should we be explicit that this is basically a shortcut to setting specific tags?
- Deprecate the `features` block for the `azuread_service_principal` resource / data source - Make all features enabling (change `visible_to_users` to `hide`) so that tag values are always set by enabling a feature
|
Test results
|
|
This functionality has been released in v2.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #327