-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] IdentityGovernance Package (accessPackages / EntitlementMangement) #612
[WIP] IdentityGovernance Package (accessPackages / EntitlementMangement) #612
Conversation
…r-azuread into feature/AccessPackagesEntitlementManagement
…r-azuread into feature/AccessPackagesEntitlementManagement
@kaovd , are you still actively working on this PR? We have a need for it and we're looking at picking up your WIP and trying to complete it. |
Will push my latest commit, had a bit of a hiatus for past month, just a few bugs left I hope 😄 |
thank you for your work! we're eagerly waiting for this one to be merged 🙏 |
@aleksei-aikashev I plan to try and revisit this in coming weeks, I did kind of expect someone to pick this up and fix the remaining bugs but will give it another go |
@kaovd, we have done a fair amount of work on this and have a WIP in the entitlement-management branch of my fork. It would be good to work with you to get these changes merged into this PR. |
Thank you! I will take a look today |
@askew Thanks for some of these fixes - Just one the ConnectedOrganisations resource / Client you've added - I don't see where msgraph.ConnectedOrganization is defined in the SDK unless you've referenced something else locally? |
It's dependent on the upstream change to the Hamilton library manicminer/hamilton#156 |
Ah ok, forgot to check the drafts - also some enums where missing that would be good to get in the same PR on access package assignment question types (TextInputQuestion, MultipleChoiceQuestion) |
any updates on this? 🙏 |
We are blocked on manicminer/hamilton#156 as we are still waiting for the maintainer to be able to obtain an appropriate test environment to run the build pipeline and tests - once its done I can pull in and take out of draft |
a bit surprised that I missed this one before starting my work in #903 , anyway raised another one for the implementation there. |
Ditching this one in favour of #903 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
There is a lot of various sub resources in the Identity Governance scope - currently WIP on EntitlementManagement / accessPackages here specifically and introducting the package as it does not exist yet
Closes #547