Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resources: directory_role and directory_role_member #573

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 13, 2021

Depends on: manicminer/hamilton#101

Closes: #50

Test results

Screenshot 2021-09-13 at 22 27 37

@manicminer manicminer added this to the v2.3.0 milestone Sep 13, 2021
@manicminer manicminer requested a review from a team September 13, 2021 17:14
@manicminer manicminer force-pushed the feature/directory-role-members branch 3 times, most recently from faf0604 to afaac3b Compare September 13, 2021 21:28
@manicminer manicminer force-pushed the feature/directory-role-members branch from afaac3b to e5059a5 Compare September 13, 2021 21:32
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some minr comments LGTM 🏗️

@manicminer manicminer force-pushed the feature/directory-role-members branch from e5059a5 to 8c11716 Compare September 16, 2021 10:31
@manicminer manicminer merged commit bcb7b3f into main Sep 16, 2021
@manicminer manicminer deleted the feature/directory-role-members branch September 16, 2021 10:33
manicminer added a commit that referenced this pull request Sep 16, 2021
manicminer added a commit that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v2.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: azuread_directory_role_member
2 participants