azuread_application: revert #355 but retain tests, must retain default application owner at create time

[manicminer]

Reverts #355

Whilst we want to enable application owners to be empty at create time, this cannot be done whilst also having the ability to retain the default owner assigned by Azure AD.

With this fix, the following applies:

• Default application owner is retained at create time
• Default owner can be overridden with one or more specified owners
• Owners cannot be forced empty at create time
• Owners can be forced empty on subsequent applies, with the caveat that Terraform must detect a config change

Fixes #365

[jackofallops]

Thanks @manicminer - LGTM 👍

[manicminer]

Test results:

[manicminer]

Linters passing locally

[ghost]

This has been released in version 1.1.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.1.1"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!