Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest go-azure-helpers with TenantOnly support for CLI authentication #345

Closed
wants to merge 1 commit into from

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Oct 28, 2020

This aims to remove remaining references to subscriptions and fully support Azure CLI authentication oriented around targeting a tenant.

Fixes: #294
Fixes: #314
Fixes: #343

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch from fb31e4b to 7b0c11a Compare November 18, 2020 16:45
@manicminer manicminer marked this pull request as ready for review November 18, 2020 22:57
@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch 2 times, most recently from 4fac544 to 3f30921 Compare November 18, 2020 23:12
@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch from 3f30921 to 7a013fe Compare November 19, 2020 12:58
@manicminer manicminer changed the title [WIP] Use latest go-azure-helpers with TenantOnly support for CLI authentication Use latest go-azure-helpers with TenantOnly support for CLI authentication Nov 19, 2020
@manicminer manicminer requested a review from a team November 19, 2020 12:59
@manicminer
Copy link
Contributor Author

I'm closing this and replacing with a new PR to trigger the new test workflows (it's also substantially changed since the original push).

@manicminer manicminer closed this Nov 19, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 1.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants