Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Go Modules #26

Merged
merged 5 commits into from
Jan 22, 2019
Merged

Switching to Go Modules #26

merged 5 commits into from
Jan 22, 2019

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff requested a review from a team January 22, 2019 13:08
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Are the acc tests doing OK after this?
I found some more stuff to fix in there once I did the move to modules.

@tombuildsstuff
Copy link
Contributor Author

@alexsomesan tests seem fine (they're eventually consistent because of an open bug, but the failures aren't unexpected)

@tombuildsstuff tombuildsstuff merged commit fd65aa3 into master Jan 22, 2019
@tombuildsstuff tombuildsstuff deleted the f/go-modules branch January 22, 2019 16:08
tombuildsstuff added a commit that referenced this pull request Jan 22, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants