-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuread_application: Added support for Required Resource Access #23
Conversation
Hi @gerardaus, Thank you for the contribution! With respect to SDK upgrades we usually do them as a separate PR from resource changes, as well as keep all packages at the same version. I have opened #24 & #25 that will update the sdk & autorest packages, once merged you should be able to merge master and only the resource changes will remain here. |
@katbyte done |
2900ad3
to
f85c696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gerardaus,
I have looked over the PR and left some comments inline. In addition could we also update the data source with these new properties?
vendor/github.com/hashicorp/terraform/helper/structure/suppress_json_diff.go
Outdated
Show resolved
Hide resolved
@katbyte good for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @gerardaus
Thanks for pushing those changes - I've taken a look through and left some minor comments in-line but this is otherwise looking good; if we can fix those up then this should be good to merge 👍
Thanks!
azuread_application
; upgrade to azure-sdk-for-go graphrbac v24.1.0azuread_application
azuread_application
@tombuildsstuff ready to roll. Assuming its good to merge, do you want me to squash those commits? |
@gerardaus, we can easily squash them via github's merge button 🙂 i'll give it a review shortly |
Thanks for the updates @gerardaus, LGTM now 🚀 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
In order to support the "Required Resource Access Type", the azure sdk needed to be upgraded.
(fixes #9)