bugfix: azuread_application - delete password block #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyTobi
force-pushed
the
remove-app-password
branch
from
89227cd to
d1fb644
Compare
HappyTobi
force-pushed
the
remove-app-password
branch
2 times, most recently
from
00f3897 to
8709641
Compare
HappyTobi
force-pushed
the
remove-app-password
branch
from
8709641 to
ccdebd9
Compare
|
Hi @katbyte I update the pr and run all the required tests: make testacc TESTARGS='-run=TestAccApplicationPassword_with_ApplicationInlinePassword' Both passed without any issue. Can you please take a look the the rebased pr? |
jackofallops
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Hi @HappyTobi - Thanks for this, just a couple minor changes to take a look at below if you could, and then I think this will be good to go.
internal/services/applications/application_password_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/applications/application_password_resource_test.go
Outdated
Show resolved
Hide resolved
jackofallops
approved these changes
Oct 18, 2024
jackofallops
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX:
Update function of application resource to update / remove the password when the inline
passwordblock is removed.