Feature: #881 Enable azuread_group to return indirect members #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @manicminer, |
|
Hello @manicminer I'd also love to see this merged, is there a chance that it will be merged? Thanks in advance! |
TomasKunka
force-pushed
the
feat/transitive-members
branch
from
7b788b6 to
82fc92e
Compare
github-actions
bot
added
dependencies
feature/service-principals
feature/applications
feature/users
feature/domains
tooling
feature/conditional-access
feature/invitations
feature/directory-roles
feature/app-role-assignments
feature/administrative-units
feature/policies
feature/user-flows
feature/identity-governance
feature/directory-objects
size/XL
and removed
size/M
labels
TomasKunka
force-pushed
the
feat/transitive-members
branch
from
82fc92e to
879ba4e
Compare
TomasKunka
force-pushed
the
feat/transitive-members
branch
from
879ba4e to
f1f0a42
Compare
manicminer
removed
feature/service-principals
feature/applications
feature/users
feature/domains
tooling
feature/conditional-access
feature/invitations
feature/directory-roles
feature/app-role-assignments
feature/administrative-units
feature/policies
feature/user-flows
feature/identity-governance
feature/directory-objects
dependencies
labels
manicminer
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks for this contribution @TomasKunka! Apologies for the delay in reviewing the PR - this is an excellent first contribution. I made a couple of minor changes, which ordinarily I'd suggest in my review but given the tardiness of this review, and the diminutive changes needed, I thought it would be helpful to update your branch and note them here.
- We generally prefer to order the attributes in a schema starting with Required properties, followed by Optional ones, and lastly any Computed attributes - with loose secondary ordering by name. I moved the
include_transitive_membersproperty further up in the schema map, alongside the other Optional properties. - Where you added an
ifstatement to check the value ofinclude_transitive_members, I moved thevar err errorstatement outside of thisifblock so that it only needs to be declared once. Very much a minor optimization. - I added the new property to the data source documentation page.
Thank you again for this addition, this LGTM 👍
|
Test results (failure is unrelated) 
|
|
Thank you for the kind words and thorough explanation @manicminer ! |
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
May 10, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
<h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azuread" updated from
"2.48.0" to "2.49.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>2.49.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.49.0
FEATURES:

*
**New Data Source:** `azuread_group_role_management_policy`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_group_role_management_policy`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_privileged_access_group_assignment_schedule`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_privileged_access_group_eligibility_schedule`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_synchronization_job_provision_on_demand`
([#1032](https://github.com/hashicorp/terraform-provider-azuread/issues/1032))

ENHANCEMENTS:

*
`data.azuread_group` - support for the `include_transitive_members`
property
([#1300](hashicorp/terraform-provider-azuread#1300
`azuread_application` - relax validation for the `identifier_uris`
property to allow more values
([#1351](hashicorp/terraform-provider-azuread#1351
`azuread_application_identifier_uri` - relax validation for the
`identifier_uri` property to allow more values
([#1351](hashicorp/terraform-provider-azuread#1351
`azuread_group` - support the `SkipExchangeInstantOn` value for the
`behaviors` property
([#1370](hashicorp/terraform-provider-azuread#1370
`azuread_user` - relax validation for the `employee_type` property to
allow more values
([#1328](https://github.com/hashicorp/terraform-provider-azuread/issues/1328))

BUG
FIXES:

* `azuread_application_pre_authorized` - fix a
destroy-time bug that could prevent deletion of the resource
([#1299](https://github.com/hashicorp/terraform-provider-azuread/issues/1299))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/158/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#881
Please have mercy! My first Go code and my first open source contribution.