Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: enable setting of session_controls instead of, or in addition to, grant_controls #1155

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

manicminer
Copy link
Contributor

Depends on: manicminer/hamilton#250
Fixes: #801
Fixes: #1150

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💣

@manicminer manicminer force-pushed the bugfix/conditional-access-grant-controls branch from a6489c3 to 9d4cae1 Compare July 27, 2023 14:03
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2023-07-27 at 15 42 14 Screenshot 2023-07-27 at 15 43 51

@manicminer manicminer merged commit fe9d64e into main Jul 27, 2023
@manicminer manicminer deleted the bugfix/conditional-access-grant-controls branch July 27, 2023 14:44
manicminer added a commit that referenced this pull request Jul 27, 2023
@github-actions
Copy link

This functionality has been released in v2.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants