Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find user and users by using employee ID #1040

Merged
merged 29 commits into from
Jul 13, 2023

Conversation

pchanvallon
Copy link
Contributor

@pchanvallon pchanvallon commented Mar 2, 2023

Add the possibility to azuread_user and azuread_users data sources to search Azure AD users using employee_id property.

closes #1120

@github-actions github-actions bot added the size/L label Mar 2, 2023
@pchanvallon pchanvallon changed the title feat(user): find user and users by employee ID Find user and users by employee ID Mar 2, 2023
@pchanvallon pchanvallon changed the title Find user and users by employee ID Find user and users by using employee ID Mar 2, 2023
@pchanvallon pchanvallon force-pushed the feat/find-user-by-employeeid branch 6 times, most recently from e9b22a7 to d1a3360 Compare March 7, 2023 13:35
@pchanvallon pchanvallon force-pushed the feat/find-user-by-employeeid branch 3 times, most recently from 7caa1e8 to c846075 Compare May 9, 2023 13:07
@pchanvallon
Copy link
Contributor Author

Hello @manicminer,
Is it possible to have a review on this PR ?
I'm really looking for using it on my various projects ?
Thanks a lot.

@pchanvallon pchanvallon force-pushed the feat/find-user-by-employeeid branch from c846075 to 2405f9b Compare June 23, 2023 07:12
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this contribution @pchanvallon, this LGTM 👍

docs/data-sources/users.md Outdated Show resolved Hide resolved
docs/data-sources/users.md Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v2.40.0 milestone Jul 13, 2023
@manicminer manicminer force-pushed the feat/find-user-by-employeeid branch from 50c73c4 to bf22c4d Compare July 13, 2023 23:19
@manicminer
Copy link
Contributor

Test results

Screenshot 2023-07-14 at 00 17 32

@manicminer manicminer force-pushed the feat/find-user-by-employeeid branch from bf22c4d to 3c92f75 Compare July 13, 2023 23:31
@manicminer manicminer force-pushed the feat/find-user-by-employeeid branch 4 times, most recently from d59465b to bf22c4d Compare July 13, 2023 23:50
@manicminer manicminer merged commit 89af90f into hashicorp:main Jul 13, 2023
manicminer added a commit that referenced this pull request Jul 13, 2023
@github-actions
Copy link

This functionality has been released in v2.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find users based on employee_id
10 participants