Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_service_principal: Add Tag Property #5

Closed
midacts opened this issue Dec 7, 2018 · 5 comments · Fixed by #31
Closed

azuread_service_principal: Add Tag Property #5

midacts opened this issue Dec 7, 2018 · 5 comments · Fixed by #31

Comments

@midacts
Copy link

midacts commented Dec 7, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

azurerm_azuread_service_principal: Add option for tag

New or Affected Resource(s)

  • azurerm_azuread_service_principal

Potential Terraform Configuration

resource "azurerm_azuread_service_principal" "test" {
  application_id = "${azurerm_azuread_application.test.application_id}"
  principal_tags = {
    WindowsAzureActiveDirectoryIntegratedApp = true
  }
}

References

@tombuildsstuff
Copy link
Contributor

hi @midacts

Thanks for opening this issue :)

Given there's quite a few of them and they're different to the other resources we're looking to split the Azure AD resources out of this Provider and into their own azuread provider - more information can be found in #2322 - and as such rather than implementing this in the existing resources in this provider I think it'd make sense to implement support for in the new provider; as such I'm going to block this on #2322 for the moment.

Thanks!

@midacts
Copy link
Author

midacts commented Dec 7, 2018

Thanks for the reply.
I think it is a great idea. Thanks for the link. : )

@katbyte
Copy link
Collaborator

katbyte commented Jan 10, 2019

Hi @midacts,

As in 2.0 we are deprecating all Azure AD resources and data sources in the Azure RM provider in favour of this new provider I have moved the issue here.

@katbyte katbyte transferred this issue from hashicorp/terraform-provider-azurerm Jan 10, 2019
@tombuildsstuff tombuildsstuff changed the title azurerm_azuread_service_principal: Add Tag Property azuread_service_principal: Add Tag Property Jan 10, 2019
@midacts
Copy link
Author

midacts commented Jan 11, 2019

Thanks for the heads up and for getting this issue transferred over to the terraform-provider-azuread repo.

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants