Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: support optional_claims #260

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented May 29, 2020

Support configuration of optional claims as described here and export same attriobutes with data source.

Does not yet support optional claims for SAML tokens due to SDK bug: Azure/azure-sdk-for-go#9714

Fixes: #145

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer
Copy link
Contributor Author

Tests pass
Screenshot 2020-06-02 23 15 58

@manicminer manicminer merged commit 82c97f5 into master Jun 2, 2020
manicminer added a commit that referenced this pull request Jun 2, 2020
@manicminer manicminer deleted the app/optional-claims branch June 2, 2020 22:25
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for optionalClaims in azuread_application
2 participants