Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphrbac: property 'samlToken' does not exist on type 'Microsoft.DirectoryServices.OptionalClaims' #9714

Closed
manicminer opened this issue May 29, 2020 · 6 comments
Assignees
Labels
ARM - RBAC bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.

Comments

@manicminer
Copy link

manicminer commented May 29, 2020

Bug Report

  • github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac
  • v42.1.0
  • go version go1.14.2 darwin/amd64

I'm trying to include OptionalClaims when creating an Application. I can submit claims for AccessToken and IDToken, but attempting to set claims for SamlToken I get a 400 error:

The property 'samlToken' does not exist on type 'Microsoft.DirectoryServices.OptionalClaims'. Make sure to only use property names that are defined by the type.

SDK is using the object key samlToken but I believe this is supposed to be saml2Token as described at https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-optional-claims#optionalclaims-type

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 29, 2020
@ArcturusZhang
Copy link
Member

Hi @manicminer thanks for this issue!

This should be another bug in graphrbac's swagger... I have tagged this issue so that the service team would have a look and probably update their swagger and then the SDK would pick up that update accordingly.

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2020
@ArcturusZhang ArcturusZhang added Service Attention Workflow: This issue is responsible by Azure service team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 1, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @armleads-azure.

@MarkDordoy
Copy link

Any idea when this bug will be fixed?

@MarkDordoy
Copy link

Any idea when this will be done?

@RickWinter RickWinter added the Service This issue points to a problem in the service. label Sep 13, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 13, 2021
@drem-darios
Copy link

Is there any update on this issue?

@RickWinter RickWinter added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Sep 1, 2022
@RickWinter RickWinter added this to the 2022-10 milestone Sep 1, 2022
@RickWinter RickWinter modified the milestones: 2022-10, 2023-04 Jan 10, 2023
@RickWinter RickWinter removed this from the 2023-04 milestone Aug 29, 2023
Copy link

Hi @manicminer, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARM - RBAC bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Projects
None yet
Development

No branches or pull requests

5 participants