Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade azure-sdk-for-go from v21.3.0 -> v24.1.0 #25

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 22, 2019

Builds off #24 (and that should be merged first)

(fixes #17)

@katbyte katbyte added this to the 0.2.0 milestone Jan 22, 2019
@ghost ghost added the size/XXL label Jan 22, 2019
@katbyte katbyte changed the title Upgrade azure-sdk-for-go from v21.3.0 -> v24.0.0 Upgrade azure-sdk-for-go from v21.3.0 -> v24.1.0 Jan 22, 2019
@katbyte
Copy link
Collaborator Author

katbyte commented Jan 22, 2019

[21:31:39] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azuread▸dep/sdk-24.1.0$ make fmt; make testacc TEST=./azuread TESTARGS=-test.run=TestAcc
==> Fixing source code with gofmt...
gofmt -s -w ./azuread
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azuread -v -test.run=TestAcc -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azuread/version.ProviderVersion=acc"
=== RUN   TestAccAzureADApplicationDataSource_byObjectId
=== PAUSE TestAccAzureADApplicationDataSource_byObjectId
=== RUN   TestAccAzureADApplicationDataSource_byObjectIdComplete
=== PAUSE TestAccAzureADApplicationDataSource_byObjectIdComplete
=== RUN   TestAccAzureADApplicationDataSource_byName
=== PAUSE TestAccAzureADApplicationDataSource_byName
=== RUN   TestAccAzureADServicePrincipalDataSource_byApplicationId
=== PAUSE TestAccAzureADServicePrincipalDataSource_byApplicationId
=== RUN   TestAccAzureADServicePrincipalDataSource_byDisplayName
=== PAUSE TestAccAzureADServicePrincipalDataSource_byDisplayName
=== RUN   TestAccAzureADServicePrincipalDataSource_byObjectId
=== PAUSE TestAccAzureADServicePrincipalDataSource_byObjectId
=== RUN   TestAccAzureADApplication_basic
=== PAUSE TestAccAzureADApplication_basic
=== RUN   TestAccAzureADApplication_availableToOtherTenants
=== PAUSE TestAccAzureADApplication_availableToOtherTenants
=== RUN   TestAccAzureADApplication_complete
=== PAUSE TestAccAzureADApplication_complete
=== RUN   TestAccAzureADApplication_update
=== PAUSE TestAccAzureADApplication_update
=== RUN   TestAccAzureADServicePrincipalPassword_basic
=== PAUSE TestAccAzureADServicePrincipalPassword_basic
=== RUN   TestAccAzureADServicePrincipalPassword_requiresImport
--- SKIP: TestAccAzureADServicePrincipalPassword_requiresImport (0.00s)
    resource_service_principal_password_test.go:47: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureADServicePrincipalPassword_customKeyId
=== PAUSE TestAccAzureADServicePrincipalPassword_customKeyId
=== RUN   TestAccAzureADServicePrincipal_basic
=== PAUSE TestAccAzureADServicePrincipal_basic
=== CONT  TestAccAzureADApplicationDataSource_byObjectId
=== CONT  TestAccAzureADApplication_availableToOtherTenants
=== CONT  TestAccAzureADServicePrincipalPassword_customKeyId
=== CONT  TestAccAzureADServicePrincipalDataSource_byDisplayName
=== CONT  TestAccAzureADApplication_update
=== CONT  TestAccAzureADApplication_basic
=== CONT  TestAccAzureADApplication_complete
=== CONT  TestAccAzureADServicePrincipalDataSource_byApplicationId
--- PASS: TestAccAzureADApplication_complete (3.21s)
=== CONT  TestAccAzureADServicePrincipalPassword_basic
--- PASS: TestAccAzureADApplication_availableToOtherTenants (3.94s)
=== CONT  TestAccAzureADServicePrincipalDataSource_byObjectId
--- PASS: TestAccAzureADApplication_update (4.00s)
=== CONT  TestAccAzureADServicePrincipal_basic
--- PASS: TestAccAzureADServicePrincipalDataSource_byApplicationId (4.90s)
=== CONT  TestAccAzureADApplicationDataSource_byObjectIdComplete
--- PASS: TestAccAzureADApplicationDataSource_byObjectId (4.92s)
=== CONT  TestAccAzureADApplicationDataSource_byName
--- PASS: TestAccAzureADServicePrincipalDataSource_byDisplayName (5.57s)
--- PASS: TestAccAzureADApplication_basic (6.90s)
--- PASS: TestAccAzureADServicePrincipalPassword_customKeyId (7.29s)
--- PASS: TestAccAzureADServicePrincipalDataSource_byObjectId (4.72s)
--- PASS: TestAccAzureADApplicationDataSource_byObjectIdComplete (3.82s)
--- PASS: TestAccAzureADApplicationDataSource_byName (4.08s)
--- PASS: TestAccAzureADServicePrincipal_basic (5.05s)
--- PASS: TestAccAzureADServicePrincipalPassword_basic (6.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azuread/azuread	10.015s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit bef0db7 into master Jan 22, 2019
@katbyte katbyte deleted the dep/sdk-24.1.0 branch January 22, 2019 10:34
katbyte added a commit that referenced this pull request Jan 22, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update azure-go-sdk to v23.0.0 (or later)
2 participants