Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group_membership_claims missing support got ApplicationGroup #239

Closed
MarkDordoy opened this issue Apr 9, 2020 · 2 comments
Closed

group_membership_claims missing support got ApplicationGroup #239

MarkDordoy opened this issue Apr 9, 2020 · 2 comments

Comments

@MarkDordoy
Copy link
Contributor

MarkDordoy commented Apr 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The api supports updating an applications group_membership_claims to support ApplicationGroup so the terraform provider should also support this, as it is a handy workaround when users are members or more groups than a SAML response can hold

New or Affected Resource(s)

  • azuread_application

Potential Terraform Configuration

resource "azuread_application" "application" {
  name                       = "myApp
  homepage                   = "https://myapp.com"
  identifier_uris            = "https://myapp.com"
  reply_urls                 = "https://myapp.com/saml/acs"
  available_to_other_tenants = false
  oauth2_allow_implicit_flow = false
  group_membership_claims    = "ApplicationGroup"
  type                       = "webapp/api"
}

References

Github issue open for support in SDK for enum type: Azure/azure-sdk-for-go#8244

PR to fix this for this repo: #238

katbyte pushed a commit that referenced this issue May 14, 2020
Added support to use ApplicationGroup as a valid group_membership_claims option.

Updated docs to include this also

Issue detailing this change can be found here #239
@katbyte katbyte added this to the v0.9.0 milestone May 14, 2020
@katbyte katbyte closed this as completed May 14, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants