-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuread_application - the group_membership_claims
now supports ApplicationGroup
#238
azuread_application - the group_membership_claims
now supports ApplicationGroup
#238
Conversation
@katbyte be great if we can get this merged and a release cut so i can use this feature asap. Thanks in advance |
Can this repo please get some love and attention and consistent cadence on change please. |
@katbyte @tombuildsstuff anyone around to help get this in and a new release cut? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @MarkDordoy! overall looks great but needed a test. Hope you don't mind but i've pushed the required changes to get this merged 🙂 LGTM 🚀
group_membership_claims
now supports ApplicationGroup
This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azuread" {
version = "~> 0.9.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Added support to use ApplicationGroup as a valid group_membership_claims option.
Updated docs to include this also
Issue detailing this change can be found here #239