Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application - the group_membership_claims now supports ApplicationGroup #238

Merged
merged 4 commits into from
May 14, 2020
Merged

azuread_application - the group_membership_claims now supports ApplicationGroup #238

merged 4 commits into from
May 14, 2020

Conversation

MarkDordoy
Copy link
Contributor

@MarkDordoy MarkDordoy commented Apr 9, 2020

Added support to use ApplicationGroup as a valid group_membership_claims option.

Updated docs to include this also

Issue detailing this change can be found here #239

@MarkDordoy
Copy link
Contributor Author

@katbyte be great if we can get this merged and a release cut so i can use this feature asap.

Thanks in advance

@MarkDordoy
Copy link
Contributor Author

Can this repo please get some love and attention and consistent cadence on change please.

@MarkDordoy
Copy link
Contributor Author

@katbyte @tombuildsstuff anyone around to help get this in and a new release cut?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @MarkDordoy! overall looks great but needed a test. Hope you don't mind but i've pushed the required changes to get this merged 🙂 LGTM 🚀

@katbyte katbyte merged commit d701e9e into hashicorp:master May 14, 2020
@katbyte katbyte changed the title Added support for ApplicationGroup azuread_application - the group_membership_claims now supports ApplicationGroup May 14, 2020
katbyte added a commit that referenced this pull request May 14, 2020
@MarkDordoy MarkDordoy deleted the md/support-application-group branch May 14, 2020 08:03
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants