Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting client ID / secret through files #1189

Merged

Conversation

mpminardi
Copy link
Contributor

@mpminardi mpminardi commented Sep 13, 2023

Adds the ability to specify a path to the client ID and client secret in place of supplying their values directly in the provider.

This adds matching capabilities to what was added to the AzureRM provider in hashicorp/terraform-provider-azurerm#21764

@mpminardi mpminardi marked this pull request as ready for review September 14, 2023 15:34
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @mpminardi, this LGTM 👍

Test results

Screenshot 2023-09-14 at 23 58 41

@manicminer manicminer added this to the v2.42.0 milestone Sep 14, 2023
@manicminer manicminer merged commit a924023 into hashicorp:main Sep 14, 2023
8 checks passed
manicminer added a commit that referenced this pull request Sep 14, 2023
@github-actions
Copy link

This functionality has been released in v2.42.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants