Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_access_package_assignment_policy: support Manager value for review_type #1159

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

manicminer
Copy link
Contributor

Closes: #1149

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2023-07-27 at 01 10 24

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@manicminer manicminer force-pushed the f/access-review-reviewer-type-manager branch from b4db326 to 4dc9b5f Compare July 27, 2023 14:46
@manicminer manicminer changed the title azuread_access_packagassignment_policy: support Manager value for review_type azuread_access_package_assignment_policy: support Manager value for review_type Jul 27, 2023
@manicminer manicminer merged commit 057cadb into main Jul 27, 2023
@manicminer manicminer deleted the f/access-review-reviewer-type-manager branch July 27, 2023 14:48
manicminer added a commit that referenced this pull request Jul 27, 2023
@github-actions
Copy link

This functionality has been released in v2.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tjrobinson
Copy link

Thanks all!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review_type in azuread_access_package_assignment_policy should accept Manager
3 participants