Merge pull request #1159 from hashicorp/f/access-review-reviewer-type…

…-manager azuread_access_package_assignment_policy: support `Manager` value for `review_type`
hashicorp · Jul 27, 2023 · 057cadb · 057cadb
2 parents 698f368 + 4dc9b5f
commit 057cadb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/resources/access_package_assignment_policy.md b/docs/resources/access_package_assignment_policy.md
@@ -124,7 +124,7 @@ resource "azuread_access_package_assignment_policy" "test" {
 - `duration_in_days` (Number) How many days each occurrence of the access review series will run.
 - `enabled` (Optional) Whether to enable assignment review.
 - `review_frequency` (Optional) This will determine how often the access review campaign runs, valid values are `weekly`, `monthly`, `quarterly`, `halfyearly`, or `annual`.
-- `review_type` (Optional) Self review or specific reviewers. Valid values are `Self`, or `Reviewers`.
+- `review_type` (Optional) Self-review or specific reviewers. Valid values are `Manager`, `Reviewers`, or `Self`.
 - `reviewer` (Optional) One or more `reviewer` blocks to specify the users who will be reviewers (when `review_type` is `Reviewers`), as documented below.
 - `starting_on` (Optional) This is the date the access review campaign will start on, formatted as an RFC3339 date string in UTC(e.g. 2018-01-01T01:02:03Z), default is now. Once an access review has been created, you cannot update its start date
 

diff --git a/internal/services/identitygovernance/access_package_assignment_policy_resource.go b/internal/services/identitygovernance/access_package_assignment_policy_resource.go
@@ -241,8 +241,9 @@ func accessPackageAssignmentPolicyResource() *schema.Resource {
 							Type:        schema.TypeString,
 							Optional:    true,
 							ValidateFunc: validation.StringInSlice([]string{
-								msgraph.AccessReviewReviewerTypeSelf,
+								msgraph.AccessReviewReviewerTypeManager,
 								msgraph.AccessReviewReviewerTypeReviewers,
+								msgraph.AccessReviewReviewerTypeSelf,
 							}, false),
 						},