Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add created_at attribute to lightsail instance documentation #9977

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Add created_at attribute to lightsail instance documentation #9977

merged 2 commits into from
Sep 5, 2019

Conversation

blckct
Copy link
Contributor

@blckct blckct commented Sep 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Update the lightsail instance to add a missing attribute. It's already returned by the resource but just wasn't in the documentation.

@blckct blckct requested a review from a team September 3, 2019 22:26
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. labels Sep 3, 2019
@blckct blckct changed the title Add created_add attribute to lightsail instance documentation Add created_at attribute to lightsail instance documentation Sep 3, 2019
ryndaniels
ryndaniels suggested changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @blckct - thanks for this PR! If you take a look towards the bottom of the file, you'll see that there's already an existing Attributes Reference section, so if you could move the created_at attribute into that rather than creating a duplicate section, we can go ahead and get this merged. Thanks! 🙂

@blckct blckct force-pushed the aws_lighstail_add_created_at branch from 928e415 to 7d17c8f Compare September 5, 2019 09:34
@blckct blckct force-pushed the aws_lighstail_add_created_at branch from 7d17c8f to 6b1d0ab Compare September 5, 2019 09:35
@blckct
Copy link
Contributor Author

blckct commented Sep 5, 2019

@ryndaniels Well, that was embarrassing, sorry. Fixed now.

ryndaniels
ryndaniels approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blckct no worries! 🙂 Just a quick minor grammatical nitpick and then this is good to go! 👍

website/docs/r/lightsail_instance.html.markdown Outdated Show resolved Hide resolved
@blckct
Copy link
Contributor Author

blckct commented Sep 5, 2019

@ryndaniels Yeah, that seems good.

@ryndaniels ryndaniels added this to the v2.27.0 milestone Sep 5, 2019
@ryndaniels ryndaniels merged commit 3ec4261 into hashicorp:master Sep 5, 2019
@ghost
Copy link

ghost commented Sep 5, 2019

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blckct @ryndaniels