New resource: aws_apigatewayv2_domain_name

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_domain_name

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2DomainName_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2DomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2DomainName_basic
=== PAUSE TestAccAWSAPIGateway2DomainName_basic
=== RUN   TestAccAWSAPIGateway2DomainName_Tags
=== PAUSE TestAccAWSAPIGateway2DomainName_Tags
=== RUN   TestAccAWSAPIGateway2DomainName_UpdateCertificate
=== PAUSE TestAccAWSAPIGateway2DomainName_UpdateCertificate
=== CONT  TestAccAWSAPIGateway2DomainName_basic
=== CONT  TestAccAWSAPIGateway2DomainName_UpdateCertificate
=== CONT  TestAccAWSAPIGateway2DomainName_Tags
--- PASS: TestAccAWSAPIGateway2DomainName_basic (24.39s)
--- PASS: TestAccAWSAPIGateway2DomainName_Tags (109.44s)
--- PASS: TestAccAWSAPIGateway2DomainName_UpdateCertificate (462.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	462.743s

Currently based on #8842, will need to rebase once that PR is merged.

[ewbankkit]

Test sweeper:

$ SWEEP=us-east-2 SWEEPARGS=-sweep-run=aws_api_gateway_v2_domain_name make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./... -v -sweep=us-east-2 -sweep-run=aws_api_gateway_v2_domain_name
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
2019/07/23 14:14:18 [DEBUG] Running Sweepers for region (us-east-2):
2019/07/23 14:14:18 [INFO] Building AWS auth structure
2019/07/23 14:14:18 [INFO] Setting AWS metadata API timeout to 100ms
2019/07/23 14:14:19 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2019/07/23 14:14:19 [INFO] AWS Auth provider used: "EnvProvider"
2019/07/23 14:14:19 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2019/07/23 14:14:19 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2019/07/23 14:14:20 [INFO] Deleting API Gateway v2 domain name: ewbankkit.example.com
2019/07/23 14:14:26 Sweeper Tests ran:
	- aws_api_gateway_v2_domain_name
ok  	github.com/terraform-providers/terraform-provider-aws/aws	7.720s

[ewbankkit]

Rebased to fix merge conflict.

[ewbankkit]

After merge of #8842, incorporate all the feedback:

• Migrate to Terraform provider SDK
• Change resource name to aws_apigatewayv2_blah; Rename source files
• Remove sidebar_current from documentation
• Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
• Change function names to ApiGatewayV2
• Add _disappears acceptance test
• Use multierror in any test sweeper

[ewbankkit]

Renamed resource to aws_apigatewayv2_domain_name.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2DomainName_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2DomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2DomainName_basic
=== PAUSE TestAccAWSAPIGatewayV2DomainName_basic
=== RUN   TestAccAWSAPIGatewayV2DomainName_disappears
=== PAUSE TestAccAWSAPIGatewayV2DomainName_disappears
=== RUN   TestAccAWSAPIGatewayV2DomainName_Tags
=== PAUSE TestAccAWSAPIGatewayV2DomainName_Tags
=== RUN   TestAccAWSAPIGatewayV2DomainName_UpdateCertificate
=== PAUSE TestAccAWSAPIGatewayV2DomainName_UpdateCertificate
=== CONT  TestAccAWSAPIGatewayV2DomainName_basic
=== CONT  TestAccAWSAPIGatewayV2DomainName_UpdateCertificate
=== CONT  TestAccAWSAPIGatewayV2DomainName_Tags
=== CONT  TestAccAWSAPIGatewayV2DomainName_disappears
--- PASS: TestAccAWSAPIGatewayV2DomainName_disappears (26.83s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_UpdateCertificate (147.36s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_Tags (185.33s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_basic (251.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	252.396s

[ewbankkit]

This is now ready for review.

[gdavison]

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2DomainName_disappears (112.07s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_basic (178.03s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_Tags (255.62s)
--- PASS: TestAccAWSAPIGatewayV2DomainName_UpdateCertificate (370.67s)

[ghost]

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!