Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/provider: Clarify Resource Naming guidelines in Contributing Guide #9347

Merged
merged 2 commits into from
Jul 16, 2019
Merged

docs/provider: Clarify Resource Naming guidelines in Contributing Guide #9347

merged 2 commits into from
Jul 16, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 16, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

A few references (off top of my head):

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

@bflad bflad added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 16, 2019
@bflad bflad requested a review from a team July 16, 2019 09:33
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 16, 2019
@bflad bflad mentioned this pull request Jul 16, 2019
Merged
nywilken
nywilken approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.20.0 milestone Jul 16, 2019
@bflad bflad merged commit 551251e into master Jul 16, 2019
@bflad bflad deleted the d-contributing-resource-naming branch July 16, 2019 13:23
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken