Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying default behavior network interface delete_on_termination for launch templates. #8495

Closed

Conversation

willswank
Copy link

Improves the documentation for network interface delete_on_termination for launch templates by specifying the default behavior as False. Current documentation can be found at: https://www.terraform.io/docs/providers/aws/r/launch_template.html#network-interfaces

Perhaps the default behavior should be True but I believe there is a separate issue opened for that proposal.

This is worth posting to the site immediately for the current version

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 1, 2019
@savar
Copy link
Contributor

savar commented May 13, 2019

that's actually not the right thing to do. The documentation is correct. The terraform-provider-aws has a bug inside.

@aeschright aeschright self-assigned this Jun 21, 2019
@aeschright aeschright requested a review from a team June 25, 2019 19:12
@aeschright aeschright removed their assignment Jul 12, 2019
@bflad
Copy link
Contributor

bflad commented Jul 2, 2020

Hi @willswank 👋 Thank you for submitting this and apologies this was missed previously during related efforts. It appears a similar documentation change was handled via #13546. We anticipate the behavior fixes for this argument will occur with #8612, to be released with version 3.0.0 of the Terraform AWS Provider.

@bflad bflad closed this Jul 2, 2020
@ghost
Copy link

ghost commented Aug 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants