Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Cloudwatch Log Groups Data Source #7947

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7928

Changes proposed in this pull request:

  • Add aws_cloudwatch_log_groups data source

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource -timeout 120m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource (82.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.261s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchlogs tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 14, 2019
@gingermike
Copy link

+1

Is there any movement on this? I need this functionality in order to conditionally create a log group

@oxlade39
Copy link

+1

@teraken0509 teraken0509 force-pushed the feature/add-support-aws_cloudwatch_log_groups-data-source branch from b602a4c to b57797d Compare May 17, 2019 02:10
@teraken0509
Copy link
Contributor Author

Rerun test.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource -timeout 120m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource (96.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.874s

@teraken0509 teraken0509 force-pushed the feature/add-support-aws_cloudwatch_log_groups-data-source branch from b57797d to 105560c Compare June 17, 2019 13:35
@teraken0509
Copy link
Contributor Author

Re-run acctest.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource -timeout 120m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource (86.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.094s

@aeschright aeschright requested a review from a team June 26, 2019 00:51
@teraken0509 teraken0509 force-pushed the feature/add-support-aws_cloudwatch_log_groups-data-source branch from 105560c to 69fbfe5 Compare January 16, 2020 08:28
@teraken0509
Copy link
Contributor Author

Re-run acctest.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource -timeout 120m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource (101.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	101.662s

@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

Base automatically changed from master to main January 23, 2021 00:55
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:55
@ewbankkit
Copy link
Contributor

Superseded by #17151.

@teraken0509 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit closed this Sep 21, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Source aws_cloudwatch_log_groups
5 participants