Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_ram_principal_association #7563

Merged
merged 4 commits into from
Feb 14, 2019
Merged

New Resource: aws_ram_principal_association #7563

merged 4 commits into from
Feb 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 14, 2019

Closes #6527

Output from acceptance testing:

--- PASS: TestAccAwsRamPrincipalAssociation_disappears (13.98s)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (16.77s)

gazoakley and others added 3 commits January 21, 2019 22:26
@gazoakley
Add aws_ram_principal_association resource
98d8213
@bflad
Merge branch 'f-ram-resource-principal-association' of https://github…
d86dbe7 
….com/gazoakley/terraform-provider-aws into gazoakley-f-ram-resource-principal-association
@bflad
resource/aws_ram_principal_association: Finish implementation
3ec2981 
Output from acceptance testing:

```
--- PASS: TestAccAwsRamPrincipalAssociation_disappears (13.98s)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (16.77s)
```
@bflad bflad added new-resource Introduces a new resource. service/ram Issues and PRs that pertain to the ram service. labels Feb 14, 2019
@bflad bflad added this to the v1.59.0 milestone Feb 14, 2019
@bflad bflad requested a review from a team February 14, 2019 19:03
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 14, 2019
nywilken
nywilken approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad mentioned this pull request Feb 14, 2019
Merged
@bflad bflad merged commit c8cc9b6 into master Feb 14, 2019
@bflad bflad deleted the gazoakley-f-ram-resource-principal-association branch February 14, 2019 21:26
bflad added a commit that referenced this pull request Feb 14, 2019
@bflad
Update CHANGELOG for #7219 and #7563
9dcaa13
@bflad
Copy link
Contributor Author

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ram Issues and PRs that pertain to the ram service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.59.0
Development

Successfully merging this pull request may close these issues.

Feature Request: AWS Resource Access Manager
3 participants
@bflad @nywilken @gazoakley