-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing aws elastic cache cluster_id validation to allow 30 characters. #7409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
the
service/elasticache
Issues and PRs that pertain to the elasticache service.
label
Feb 4, 2019
bflad
added a commit
that referenced
this pull request
Aug 30, 2019
…ntifiers This also switches some of the hardcoded us-west-2 testing to use the aws_availability_zones data source so the testing is more region agnostic. Now its at least possible to run parallel testing locally in us-east-1 of an EC2-Classic enabled AWS account. References: - #9906 - #9131 - #7409 - #5381 Output from acceptance testing: ``` --- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (515.21s) --- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (507.64s) --- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (663.59s) --- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (595.65s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1260.72s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1303.63s) --- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (737.16s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (954.44s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (1022.11s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (995.54s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1038.00s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (958.56s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (6.63s) --- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (596.16s) --- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (576.63s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1214.33s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (8.37s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1884.91s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1746.94s) --- PASS: TestAccAWSElasticacheCluster_SecurityGroup (626.97s) --- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1167.22s) --- PASS: TestAccAWSElasticacheCluster_vpc (646.18s) --- PASS: TestAccAWSElasticacheReplicationGroup_basic (1857.56s) --- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (10.99s) --- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1875.48s) --- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3713.74s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1419.18s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (734.55s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1917.01s) --- PASS: TestAccAWSElasticacheReplicationGroup_importBasic (806.91s) --- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (950.44s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (2821.85s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2029.86s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1919.87s) --- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (737.16s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1240.24s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1047.59s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1985.53s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (900.33s) --- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (594.69s) --- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1355.75s) ```
The Elasticache service now supports cluster identifiers up to 50 characters. We will support this new limit via: #9941 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
service/elasticache
Issues and PRs that pertain to the elasticache service.
size/XS
Managed by automation to categorize the size of a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current elastic cache validator does not allow more than 20 characters in the cluster_id leading to terraform apply issues for clusters imported from AWS that have cluster_id > 20 characters. They fail with error:
Changes proposed in this pull request:
Output from acceptance testing: