Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constraint information for WAF Rule metric name #6456

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Add constraint information for WAF Rule metric name #6456

merged 1 commit into from
Nov 14, 2018

Conversation

praveensastry
Copy link
Contributor

Changes proposed in this pull request:

  • Adding constraints that specify valid values for WAF Rule metric name

version: 0.11.10

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. labels Nov 14, 2018
@bflad bflad added this to the v1.44.0 milestone Nov 14, 2018
bflad
bflad approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @praveensastry! 🚀

Matches:

@bflad bflad merged commit aa080a9 into hashicorp:master Nov 14, 2018
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@praveensastry @bflad