Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.12 examples format #6417

Merged
merged 4 commits into from
Nov 12, 2018
Merged

0.12 examples format #6417

merged 4 commits into from
Nov 12, 2018

Conversation

tracypholmes
Copy link
Contributor

Ran tf fmt against AWS documentation to match 0.12 formatting.

@tracypholmes tracypholmes requested a review from a team November 9, 2018 23:17
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/inspector Issues and PRs that pertain to the inspector service. service/iot Issues and PRs that pertain to the iot service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/pricing Issues and PRs that pertain to the pricing service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/ssm Issues and PRs that pertain to the ssm service. labels Nov 9, 2018
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/applicationautoscaling service/emr Issues and PRs that pertain to the emr service. and removed size/XXL Managed by automation to categorize the size of a PR. labels Nov 9, 2018
@ghost ghost added service/firehose Issues and PRs that pertain to the firehose service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/route53 Issues and PRs that pertain to the route53 service. service/ses Issues and PRs that pertain to the ses service. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Nov 9, 2018
bflad
bflad approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tracypholmes! 🚀 None of these changes look 0.11 backwards incompatible so we can likely just merge this into master instead.

@tracypholmes tracypholmes changed the base branch from v2.0.0-dev to master November 12, 2018 16:01
@bflad bflad added this to the v1.44.0 milestone Nov 12, 2018
@tracypholmes tracypholmes merged commit 93d9804 into master Nov 12, 2018
@tracypholmes tracypholmes deleted the 0.12-examples-format branch November 12, 2018 19:11
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/firehose Issues and PRs that pertain to the firehose service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/inspector Issues and PRs that pertain to the inspector service. service/iot Issues and PRs that pertain to the iot service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/pricing Issues and PRs that pertain to the pricing service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. service/ses Issues and PRs that pertain to the ses service. service/ssm Issues and PRs that pertain to the ssm service. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tracypholmes @bflad