Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudwatch_metric_alarm: Accept EC2 automate reboot ARN #6405

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 8, 2018

Fixes #6386

reboot was documented under OKActions but not AlarmActions in https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_PutMetricAlarm.html, but turns out is supported in AlarmActions.

Previously:

--- FAIL: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (9.08s)
    testing.go:538: Step 0 error: Error planning: 2 errors occurred:
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" doesn't look like a valid ARN ("^arn:[\\w-]+:([a-zA-Z0-9\\-])+:([a-z]{2}-(gov-)?[a-z]+-\\d{1})?:(\\d{12})?:(.*)$"): "arn:aws:automate:us-west-2:ec2:reboot"
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" does not match EC2 automation ARN ("^arn:[\\w-]+:automate:[\\w-]+:ec2:(recover|stop|terminate)$"): "arn:aws:automate:us-west-2:ec2:reboot"
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (194.97s)

Previously:

```
--- FAIL: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (9.08s)
    testing.go:538: Step 0 error: Error planning: 2 errors occurred:
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" doesn't look like a valid ARN ("^arn:[\\w-]+:([a-zA-Z0-9\\-])+:([a-z]{2}-(gov-)?[a-z]+-\\d{1})?:(\\d{12})?:(.*)$"): "arn:aws:automate:us-west-2:ec2:reboot"
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" does not match EC2 automation ARN ("^arn:[\\w-]+:automate:[\\w-]+:ec2:(recover|stop|terminate)$"): "arn:aws:automate:us-west-2:ec2:reboot"
```

```
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (194.97s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. labels Nov 8, 2018
@bflad bflad added this to the v1.43.1 milestone Nov 8, 2018
@bflad bflad requested a review from a team November 8, 2018 23:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 8, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit b987318 into master Nov 9, 2018
@bflad bflad deleted the b-aws_cloudwatch_metric_alarm-ec2-automate-reboot branch November 9, 2018 18:38
bflad added a commit that referenced this pull request Nov 9, 2018
@bflad
Copy link
Contributor Author

bflad commented Nov 9, 2018

This has been released in version 1.43.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_metric_alarm "arn:aws:automate:${var.region}:ec2:recover does not match regexp
2 participants