gosimple: Fix WAF-related issues

[YakDriver]

Related to #6343 technical debt

Changes proposed in this pull request:

• Fixes for all WAF-related tests and resources

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafByteMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafByteMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafByteMatchSet_basic
=== PAUSE TestAccAWSWafByteMatchSet_basic
=== CONT  TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (16.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.916s

$ make testacc TESTARGS='-run=TestAccAWSWafRuleGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRuleGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRuleGroup_basic
=== PAUSE TestAccAWSWafRuleGroup_basic
=== CONT  TestAccAWSWafRuleGroup_basic
--- PASS: TestAccAWSWafRuleGroup_basic (21.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.154s

$ make testacc TESTARGS='-run=TestAccAWSWafSizeConstraintSet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafSizeConstraintSet_disappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafSizeConstraintSet_disappears
=== PAUSE TestAccAWSWafSizeConstraintSet_disappears
=== CONT  TestAccAWSWafSizeConstraintSet_disappears
--- PASS: TestAccAWSWafSizeConstraintSet_disappears (16.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.865s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalSqlInjectionMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalSqlInjectionMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_basic
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_basic (18.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.188s

$ make testacc TESTARGS='-run=TestAccAWSWafXssMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafXssMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafXssMatchSet_basic
=== PAUSE TestAccAWSWafXssMatchSet_basic
=== CONT  TestAccAWSWafXssMatchSet_basic
--- PASS: TestAccAWSWafXssMatchSet_basic (18.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.068s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalIPSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalIPSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalIPSet_basic
=== PAUSE TestAccAWSWafRegionalIPSet_basic
=== CONT  TestAccAWSWafRegionalIPSet_basic
--- PASS: TestAccAWSWafRegionalIPSet_basic (17.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.384s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRule_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalRule_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalRule_basic
=== PAUSE TestAccAWSWafRegionalRule_basic
=== CONT  TestAccAWSWafRegionalRule_basic
--- PASS: TestAccAWSWafRegionalRule_basic (31.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.368s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRuleGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalRuleGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalRuleGroup_basic
=== PAUSE TestAccAWSWafRegionalRuleGroup_basic
=== CONT  TestAccAWSWafRegionalRuleGroup_basic
--- PASS: TestAccAWSWafRegionalRuleGroup_basic (24.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.707s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalSizeConstraintSet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalSizeConstraintSet_disappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalSizeConstraintSet_disappears
=== PAUSE TestAccAWSWafRegionalSizeConstraintSet_disappears
=== CONT  TestAccAWSWafRegionalSizeConstraintSet_disappears
--- PASS: TestAccAWSWafRegionalSizeConstraintSet_disappears (15.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.170s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalWebAclAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalWebAclAssociation -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalWebAclAssociation_basic
=== PAUSE TestAccAWSWafRegionalWebAclAssociation_basic
=== RUN   TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
=== PAUSE TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
=== CONT  TestAccAWSWafRegionalWebAclAssociation_basic
=== CONT  TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
--- PASS: TestAccAWSWafRegionalWebAclAssociation_multipleAssociations (255.93s)
--- PASS: TestAccAWSWafRegionalWebAclAssociation_basic (265.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	265.754s

[bflad]

LGTM, passes WAF acceptance testing just fine as well. Thanks, @YakDriver! 🚀

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!