Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/service/iam: Further clarify issues with aws_iam_policy_attachment resource #6400

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 8, 2018

Reference (among lots of others 😄): #6397

The aws_iam_policy_attachment resource should likely be deprecated in the future as its usage is limited and confusing, but that discussion will happen outside of this documentation fix.

Changes proposed in this pull request:

  • Clarify warning in aws_iam_policy_attachment to include Terraform resources as well
  • Add notes in each affected resource about the conflicting management

Output from acceptance testing: N/A

@bflad bflad added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. labels Nov 8, 2018
@bflad bflad requested a review from a team November 8, 2018 16:02
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Nov 8, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.43.1 milestone Nov 8, 2018
@bflad bflad merged commit 368dfc3 into master Nov 8, 2018
@bflad bflad deleted the d-aws_iam_policy_document-more-clarification branch November 8, 2018 16:12
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants